gravitino icon indicating copy to clipboard operation
gravitino copied to clipboard
Published 1 week ago • verified publisher icon apache

[#1908] Fix: In HadoopCatalogOperations.java field entity is not used

Open poojatalele opened this issue 1 year ago • 4 comments

What changes were proposed in this pull request?

Removed the unused entity variable in the alterSchema method of HadoopCatalogOperations.java. The refactored code now directly updates the schema and retrieves the updated schema entity for returning.

Why are the changes needed?

The entity variable was assigned but never used, which was flagged as a possible bug. Removing this unused variable makes the code cleaner and easier to maintain.

Fix: #1908

Does this PR introduce any user-facing change?

No, this PR does not introduce any user-facing changes.

How was this patch tested?

  1. Ensured all existing tests related to schema operations pass successfully.
  2. Manually verified the functionality of schema updates to confirm no regressions were introduced.

poojatalele avatar Aug 04 '24 16:08 poojatalele

@poojatalele Please resolve the code format problem, more detail can be seen in the output of CI.

yuqi1129 avatar Aug 05 '24 01:08 yuqi1129

@poojatalele Please resolve the code format problem, more detail can be seen in the output of CI.

@yuqi1129 Can you please help me with this?

poojatalele avatar Aug 05 '24 11:08 poojatalele

You ned to run ./gradlew :catalogs:catalog-hadoop:spotlessApply and commit the changes to fix the CI issue.

justinmclean avatar Aug 05 '24 23:08 justinmclean

You ned to run ./gradlew :catalogs:catalog-hadoop:spotlessApply and commit the changes to fix the CI issue.

Pls check now once @justinmclean

poojatalele avatar Aug 07 '24 06:08 poojatalele

You ned to run ./gradlew :catalogs:catalog-hadoop:spotlessApply and commit the changes to fix the CI issue.

Pls check now once @justinmclean

Any update?

poojatalele avatar Aug 14 '24 19:08 poojatalele