Justin Fagnani

Results 342 comments of Justin Fagnani

@Dav1dde we added `@queryAsync` for a very specific internal use-case, I'm not sure how `@queryAllAsync` fits, but it sounds reasonable to me. @sorvell what do you think about this one?

Isn't the return type just `Component`? (ie, ForwardRef shouldn't change the external type). Can we just extract this into a helper type?: ```ts // Props the user is allowed to...

Interesting. I think the devil is in the details here. What happens in cases of conflicts, like: ```ts return html` `; ``` Last wins I presume?

The markers are needed for bookkeeping so that lit-html knows what DOM nodes are associated with what expressions. Ideally your tests just ignore comments so that they don't interfere with...

I think we should address this by publishing a test utility package that includes functions to strip expression markers.

We'll probably support the current decorators proposal when it ships in TypeScript and one native runtime.

I think that this is a large enough feature request that it should go through the new [Lit RFC Process](https://github.com/lit/rfcs#readme).

See this table that we can use to derive tests: https://josepharhar.github.io/react-custom-elements/

Yeah, there's a `signal` option here: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#parameters I think it's reasonable to add this as we intend to support all options. The one hangup is how to get the right...