Justin Beaty
Justin Beaty
@fballiano nice work! The polyfill definitely seems too big to just add to functions.php so I like it being separate (and not maintained by us). I think it will however...
@fballiano Bundling vendor would be okay IMO. I basically do the same thing for the sites I manage. I only use composer locally and then build it by copying vendor...
Maybe this could help: https://github.com/liborm85/composer-vendor-cleaner Not sure if it could remove the entire openmage/magento-lts dir in vendor, but maybe that can just be rm -rf’d My plans were to always...
Ah, you're right since this repo doesn't require itself. But for example the `colinmollenhour/magento-redis-session` directory could go. Anything with `"type":"magento-module",` in its `composer.json` file should be safe to remove I...
> > Maybe this could help: https://github.com/liborm85/composer-vendor-cleaner > > it seems this plugin runs BEFORE deploy, so we can't use it otherwise the deployment of modules brakes :-( Hm, what...
We might be able to do more in a PHP script as well as make it cross platform. I'll try some things.
Yes to those lines. Definitely copy method.
I am not too sure about using the `post-install-cmd` event, though. I think that's going to run when someone else requires openmage, and we shouldn't modify their vendor dir. Also,...
@fballiano Thanks for clarifying that. I still have one proposal I'm working on for the script block.
My suggestions: 1) Use ``` "magento-deploystrategy": "copy", "magento-deploystrategy-dev": "symlink" ``` 2) Change `post-install-cmd` to `build-release` and call `composer run-script build-release` in release builder workflow.