Justin Beaty
Justin Beaty
The part ` (the order confirmation email was sent)` being in the title is cumbersome. Could it be better to move it into the field table? Something like: 
I guess everyone is using the sample data. 😅 Without it: ``` `created_at` timestamp NOT NULL DEFAULT '0000-00-00 00:00:00' COMMENT 'Created At', `updated_at` timestamp NOT NULL DEFAULT '0000-00-00 00:00:00' COMMENT...
@sreichel What I'm saying is that without installing the sample data, that is how the columns are defined.
However, I'm sure it would be better to be: ``` `created_at` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP COMMENT 'Created At', `updated_at` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP COMMENT 'Updated...
> So "only" sample data needs to be updated for https://github.com/OpenMage/magento-lts/issues/4069#issuecomment-2453376772? After years it needs also some other updates ... Normally sample data shouldn't need to be updated for schema...
@ma4nn Yeah it's definitely odd because as far back as [Magento 1.6.0.0-alpha1](https://github.com/OpenMage/magento-lts/blame/a75e8625f439392a1d0cb113aa93223aa1d1a58a/app/code/core/Mage/Customer/sql/customer_setup/install-1.6.0.0.php#L62) it never had the ON UPDATE statement. Also, Varien has some constants to help up with this: ```php...
Did you try with “Send Welcome Email” box checked? It’s not the most prominently displayed option.
FYI, I have some updates to the M1 PHPStan plugin that removes some false positive errors and adds some legitimate errors. Will make a PR today or tomorrow.
@sreichel I think I found an error on the latest develop branch. If I run n98 from a git clone, it is loading the OM autoloader, not the n98 one....
> [@justinbeaty](https://github.com/justinbeaty) can you please check if I have changed it in my last commit? (I am not a at home atm) I don't see any commits more recent than...