Jonathan Underwood

Results 243 comments of Jonathan Underwood

ACK sounds good to me.

IMO NACK... this is not something the library should be throwing on. The application should decide whether to throw or not on zero length / multiple whitespace etc.

Pull requests are welcome. I have successfully created some hybrid packages like uint8array-tools.

Memo for possible solutions: - [Something like this commit](https://github.com/bitcoinjs/tiny-secp256k1/commit/5e89122ff8fd40e58dd78831b92add164ebff970) might be helpful. re: wasm_path.ts vs. wasm_path_cjs.ts but this only forks the path logic. - ESM would use import meta object...

We've been throwing around similar ideas for a while, but it's low priority right now. Pull Requests welcome, though! I was thinking of making it more generic and making an...

@dcousens I wonder if a lazy loading Proxy might be good... https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy 1. When initializing BIP39, no wordlist is loaded. 2. When *any* attribute of bip39.wordlists is accessed a getter...

I made a PR with one idea...

Made a quick dirty impl of pbkdf2 using sha.js with SHA512, 64 dlen, and 2048 iterations hard coded. It was 5x~6x slower :-| ... we should probably section this off...

I am not comfortable raising the requirement of NodeJS above v14 right now, so SubtleCrypto for Node is not possible.

Maybe after v12 EOL 2022-04-30