coinselect icon indicating copy to clipboard operation
coinselect copied to clipboard

Proposal For Segwit Update PR

Open itsMikeLowrey opened this issue 4 years ago • 5 comments

I would like to make a PR to update this library to default to segwit and other issues mentioned here. Most of the heavy work has been done in this PR.

I propose to build off this work and make 2 major changes to karel-3d's PR.

  1. Change Default Options to P2WSH Outputs and high R Sigs.
  2. Change coinSelect(utxos, targets, feeRate) to coinSelect(utxos, targets, feeRate, options) and allow developers to override the default settings with their specific cases.

Just looking for a Concept ACK before I start coding up the PR, I would hate to code the wrong thing. @junderw

itsMikeLowrey avatar Mar 19 '20 20:03 itsMikeLowrey

ACK sounds good to me.

junderw avatar Mar 21 '20 14:03 junderw

I'm also interested in this.

I'm surprised there is not more appetite to get this through. Are people using alternatives or just settling on the pre segwit fee calculation?

monokh avatar May 20 '20 08:05 monokh

I'm also interested in this. Is it happening? Did you end up using another solution, @monokh ? Thanks!

chemuto avatar Oct 29 '20 09:10 chemuto

Any news?

mahnunchik avatar Jul 13 '23 18:07 mahnunchik

https://github.com/bitcoinjs/coinselect/pull/82

LeeKorbisCa avatar Aug 30 '23 13:08 LeeKorbisCa