Jonathan Underwood
Jonathan Underwood
2, Documentation seems best
Related https://github.com/paulmillr/noble-secp256k1/pull/50
No decision is needed. bitcoinjs is now modular, so as long as you can fill the `TinySecp256k1Interface` interface it doesn't matter what library you use. In fact, I believe BitGo...
@brandonblack Do you have a link to the wrapper you created? (I remember you sent it to me a long time ago.)
As a side note, I have personally reviewed `@noble` myself. Great work.
I was actually considering making hashes also modular, but hashing it too intertwined with almost every data type in this library to split it out, so I decided against it....
@mb38 You are mixing up p2pkh and p2wpkh. Pick one. (Your generate keys is generating p2pkh address, but your send function treats it like p2sh-p2wpkh...)
you don't need p2sh. p2sh-p2pkh is not the same as p2pkh.
A few thoughts: 1. This will be fixed for segwit v1 addresses in an upcoming release (once we finish taproot support) 2. That said, console.warn was meant primarily for wallet...
As a temporary solution, though super hackey, the consuming app could do something like: ```js function wrappedFromOutputScript(script, network) { const oldWarn = console.warn console.warn = () => {} const result...