Jonathan Underwood
Jonathan Underwood
I think writing integration tests using Psbt will help uncover any shortcomings. tbh, I think when you first write an integration, just do it normally like you would with any...
Also, since (I think) we use fromOutputScript etc. within Psbt, it might be a good time to create stricter rules for segwit v1 (taproot) in the address module as well....
from|toOutputScript should take in an optional eccLib, and if there is no eccLib, skip the p2tr matching and let the logic fall down to the final Error (each function ends...
Oh yeah that's good. It's probably better to merge into this PR.
1. Needs careful consideration. 2. Needs tests.
3. If we're going to use bigint, a notable addition that should also be considered is the satoshi unit. This would also be a breaking change, but allow for forks...
Also, this exposes the methods from the public API via crypto. (we export crypto directly as is) I don't want to export these. (which is why types is not exported)
In types is fine.
> > this change will make bitcoinjs-lib unusable as-is in some environments (I'm thinking of React Native on mobile) > > Interesting, what version of which JS engine is that?...
You should put a link in the README