Julius Volz
Julius Volz
:+1: Thanks :)
Hi, thanks, interesting! Just for my understanding, was there any feature request discussion around this? Allowing labels for whole groups of rules seems like it would make sense, but not...
Yeah, it definitely makes sense to me at a first glance. Would still like to get the opinions of a few more Prometheus people, since rules are a pretty core...
> I am mostly worried that blindly adding labels to all rules and groups would add a lot of cardinalty, where it's only needed in practice for a few alerts....
> Annotations were also requested (only apply for alerting rules obviously). Interesting! I wonder if we should also do annotations here. But since annotations only apply to alerting rules, setting...
> I think to be coherent and consistent It's more consistent from one point of view, but less coherent from another (recording rules don't have annotations).
Ok, seems like everyone has been happy with adding rule group labels for now at least, so let's do that :)
Nice, it looks good to me now. Everyone else happy?
@simonpasquier Yeah, the concern makes sense. Is that an objection to the addition of rule group labels, or do you think it's still ok to merge this?
Interesting, ok! By now a few more people have voiced interest in this feature here, and I think it's at least worth considering if we get a design proposal that...