Julius Volz
Julius Volz
@qed- Great, I've adjusted the title of this issue to reflect this more clearly. I can't say yet when this is going to happen, but I think it would be...
> Note that range queries are always sorted by label sets, right at the end: https://github.com/prometheus/prometheus/blob/8b863c42dd956d35d18a7a0b39c89c86adf7cebf/promql/engine.go#L722 > > Perhaps you could mention in the documentation this is intended for instant...
Ok yeah, that makes sense. Or we could actually make it work for range queries as well, but I doubt that's worth it. So then let's just add a comment...
Awesome, thanks! I haven't studied the code changes yet (aim to do that soon), but for the tests, this is what works for me: ```bash $ node --version v16.16.0 $...
Generally looks great to me besides my one node naming comment, thanks for the extensive changes :+1: @Nexucis are you fine with the codemirror-promql changes around it as well?
Perfect, thanks! I'll merge this in the next few days then, unless @Nexucis has any complaints during that time.
Oops, we're actually getting one linter error now (just some code formatting): ``` /__w/prometheus/prometheus/web/ui/module/codemirror-promql/src/parser/vector.ts 16:9 error Replace `·And,·BinaryExpr,·MatchingModifierClause,·LabelName,·GroupingLabels,·GroupLeft,·GroupRight,·On,·Or,·Unless·` with `⏎··And,⏎··BinaryExpr,⏎··MatchingModifierClause,⏎··LabelName,⏎··GroupingLabels,⏎··GroupLeft,⏎··GroupRight,⏎··On,⏎··Or,⏎··Unless,⏎` prettier/prettier ✖ 1 problem (1 error, 0 warnings) 1 error...
:+1: I ran into the same Azure package deprecation errors as well last time, and also reverted the upgrade of that package, since the required changes seemed non-trivial and I...
:+1: besides nits