Julius Volz
Julius Volz
By the way, I'm mainly interested in opinions for now. Happy to implement something myself here at some point if there's an agreement (although it's not terribly urgent for myself...
Yup, makes sense. Ok! I'll just let this sit here for now if that's ok, until either I or someone else finds the time to implement it.
@stapelberg Hey, I'd be happy to relicense under any conditions necessary to be useful. Just wondering if we want to take exactly that code or wait for some more flexible...
Perhaps as a first step, we should add an interface for passing a mapper to a given `PrometheusSink`, and the interface methods that mapper has, and then anyone can do...
@stapelberg SGTM. Actually, besides the actual interface definition, there's work needed in the `PrometheusSink` itself to act on those mappings and dynamically generate Prometheus metric vectors (metrics with label dimensions)....
As for the mapper interface definition, perhaps it would make sense for the metric name to be treated specially (instead of being just part of the labels), because otherwise the...
Of course, I added tests for the default sampling. Sorry about that.
Thanks for pointing that out. I didn't see that the class created another instance of itself further down. As far as I understand the batch code, all that is needed...
Interesting read. One thing to watch out for is whether error messages for invalid YAML (during the YAML->JSON conversion) will be better than the current ones. Some first tests seem...
I tried `predict_linear(foo[5h], 1h)`, but I get: parse error: trailing commas not allowed in function call args I also left some comments on the design doc on questions I had.