Julius Marminge

Results 324 comments of Julius Marminge

I think we just want to be able to put a regex pattern on doc-type items too. Currently, if we put a `activeBaseRegex` on a navbar item with type `doc`,...

> Note: maybe you would want "docs" to remain highlighted when browsing any doc? (ie have a "tab-like" highlighting pattern? 🤷‍♂️ Not having any navbar item highlighted could also be...

Do you suggest we make a 3-way-toggle with dark-light-system? Would that toggle be opt-in?

I can submit a PR for this if you agree with my standpoint, but since I think this is intended I won't do anything until I hear back from you

> The UX is quite hard to design. How should the localStorage value be deemed stale? Or should we not persist that value at all? I usually don't persist it...

On https://trpc.io we override this behavior by a bit hacky script implemented here https://github.com/trpc/trpc/pull/2664/files#diff-153fbbe997755581673d0a5178895a70051650f2ed919e23186dbea31b7602ef

> I think refreshing definitely should not change the color mode—that would feel really shaky. The only question is whether we can invalidate the localStorage somehow in the following case:...

I could play around and file a PR if you like?

Happy to revert https://github.com/t3-oss/create-t3-app/pull/479/commits/3f55dac8b49ec48b20104a5d5b2e3ee861baf117 - https://github.com/t3-oss/create-t3-app/pull/479/commits/762798d23ac41d567a2e8ac18d29caaad19ef968 if you want to keep it

> I'd be in favour of keeping the new Astro/Prettier setup (for the time being). Other than that I think I agree this stuff isn't really necessary. Did you file...