create-t3-app icon indicating copy to clipboard operation
create-t3-app copied to clipboard

chore: nuke commitlint

Open juliusmarminge opened this issue 1 year ago β€’ 8 comments

Closes #

βœ… Checklist

  • [x] I have followed every step in the contributing guide (updated 2022-08-15).
  • [x] The PR title follows the convention we established conventional-commit
  • [x] I performed a functional test on my final commit

Changelog

Removing commitlint as I dont think it's necessary. We squash PRs so the individual commits aren't important for the history. We still keep the linter for the PR title.

I'm all for disabling husky all together and just relying on CI but don't feel too strongly about it.


Screenshots

[Screenshots]

πŸ’―

juliusmarminge avatar Sep 18 '22 22:09 juliusmarminge

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
create-t3-app βœ… Ready (Inspect) Visit Preview Sep 20, 2022 at 8:55AM (UTC)

vercel[bot] avatar Sep 18 '22 22:09 vercel[bot]

⚠️ No Changeset found

Latest commit: a0bbbc0a12f86da57482045405660b24fa04b2b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 18 '22 22:09 changeset-bot[bot]

⚑️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 79
🟒 Accessibility 96
🟒 Best practices 93
🟠 SEO 79
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-julius-nuke-commitlint-t3-oss.vercel.app/

github-actions[bot] avatar Sep 18 '22 22:09 github-actions[bot]

Happy to revert https://github.com/t3-oss/create-t3-app/pull/479/commits/3f55dac8b49ec48b20104a5d5b2e3ee861baf117 - https://github.com/t3-oss/create-t3-app/pull/479/commits/762798d23ac41d567a2e8ac18d29caaad19ef968 if you want to keep it

juliusmarminge avatar Sep 18 '22 22:09 juliusmarminge

Obviously I support this but I'll leave it up to y'all πŸ™

t3dotgg avatar Sep 18 '22 22:09 t3dotgg

I'd be in favour of keeping the new Astro/Prettier setup (for the time being). Other than that I think I agree this stuff isn't really necessary.

c-ehrlich avatar Sep 18 '22 22:09 c-ehrlich

I'd be in favour of keeping the new Astro/Prettier setup (for the time being). Other than that I think I agree this stuff isn't really necessary.

Did you file an issue for Astro that prettier isn’t run in the IDE for their plugin?

There are some notes here https://github.com/withastro/prettier-plugin-astro

juliusmarminge avatar Sep 18 '22 22:09 juliusmarminge

Yeah I think it makes sense.

nexxeln avatar Sep 19 '22 07:09 nexxeln