Julien Wajsberg

Results 516 comments of Julien Wajsberg

Could be fixed by https://github.com/firefox-devtools/profiler/pull/4797

Thanks! I see the `data` object is imported in the profiler marker payload `data.data`. So it ends up in `data.data.type`. I wonder if adding a marker schema for EventDispatch would...

Currently we can't access properties in nested objects, but maybe we can override the type `CompleteTraceEvent` (and others) with whatever `type` is inside the `arg` data. I'm not sure we...

Interesting! I think this is because we assume this is a sequence of events, where in the real life some operations happen in parallel. I believe that in this case...

if you have an example of a profile with this problem that you can share, that can help a lot!

The datetime errors on the `download` attribute sounds like a problem with locales. It looks like this is UTC-5 (is that toronto?) I get the same errors with `LC_ALL=C TZ="America/Toronto"...

Thanks for the report. Of course it's difficult to diagnose this... Can you please ping me when this happens with precise timestamps? I can have a look at the server...

Current idea: show the tooltip for the currently selected marker.

I think the fix isn't obvious, and we might need to rearchitecture some things. So this is definitely not easy to do.

I think the problem is that we have a few markers that are very long, and so `filterRawMarkerTableToRangeWithMarkersToDelete` keeps them because they're still visible in this committed range. Then, we...