Julien Falque

Results 125 comments of Julien Falque

Maybe we can update `@PhpCsFixer` ruleset to use `@PER` instead of `@PSR12`?

Let's add it to `@PhpCsFixer` first. We'll see later if Symfony is interested in using it as well.

Thank you @jrmajor.

According to [this article](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/) and the [events documentation](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target), this security issue only applies to `pull_request_target` and we don't seem to use it so I think we don't need it for...

What would you expect this command to do exactly?

> Instead of the expected 4, it is now 2. Your configuration says you want 2 spaces, why do you expect 4? All the changes in https://github.com/Drenso/symfony-oidc/commit/443de599380a20a122cb22e69e08a0309b06210f follow this config.

Currently PHP CS Fixer has no configuration for "continuation indent" and never had. Yes, the behavior has changed, such lines were never fixed before, but this was more of an...

Sorry about that. Sadly we don't have much free time to handle all the contributions but you're very welcome to implement this.

I'm sorry, I realize I confused this with another feature from PhpStorm I do use: soft-wraps additional indent, which is not written in the file on save. I actually agree...

Indeed, this was implemented in #4908. Thanks anyway @soyuka for working on this!