Julien Falque

Results 149 comments of Julien Falque

PR reworked. I didn't apply the new fixer to the codebase yet to ease review so builds will fail but tests should pass. I reverted proxying the new fixer in...

Honestly I'm not sure, it's quite old now :) I think this part from my previous comment: > This means there is some duplicated code now, espacially with `multiline_whitespace_before_semicolons` and...

> Can `multiline_whitespace_before_semicolons` be a proxy to `whitespace_before_statement_end`? @kubawerlos No, `multiline_whitespace_before_semicolons` only removes newlines inside whitespace tokens. The removal of singleline whitespaces is currently handled by `no_singleline_whitespace_before_semicolons` (which I forgot...

Not sure how to make fabbot happy here, any idea?

As [proposed in #5475](https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/5475#issuecomment-834302137), it might be better to deprecate the `allow_single_line_anonymous_class_with_empty_body` option to replace it with a new one that would apply to any braces instead of some specific...

@tuqqu You probably need to update rulesets to stop using the deprecated option. Tests that still use it purposely should be tagged with `@group legacy` and may use `$this->expectDeprecation()`.

By the way, @tuqqu please avoid amending/squashing commits, this forces reviewers to read the whole changes on every push. Commits will be squashed before merging anyway.

@tuqqu Indeed, [the issue also happens on `master` branch](https://github.com/FriendsOfPHP/PHP-CS-Fixer/runs/2747753773). We should fix that so you can rebase and have a green build :)