Julian Lam

Results 132 comments of Julian Lam

There is no point in putting the service worker code behind a feature flag if the code itself does not work on most browsers :frowning:

Probably something like this: 1. If `packageManager` defined in `package.json`, use that value 2. Otherwise, check `package_manager` in `config.json` (legacy) 3. Finally, use lockfile detection if all else fails (which...

@hello-smile6 is this regarding satisfying encryption at rest? If so this might be more along the lines of something you can configure Mongo, Redis, or psql to do, not NodeBB.

For what it's worth, for me it prints `true` on the first tick on Github.com. Haven't tried other sites.

Yeah I'll echo that it's probably a CORS issue. Popups loading cross-origin sites have `window.opener` as `null`. Likewise, the parent cannot interact with the child.

> Forum language: Hebrew Does this only occur with Hebrew language enabled?

A bootbox approach would add additional overhead to an already complicated system. This is not to say that it is _not_ a good idea, but simply that the uploads system...

Ah, I was confused by what you were referring to, but what I think you mean is logging in via a "magic url"? I think this kind of functionality would...