Julian Lam

Results 132 comments of Julian Lam

I am not opposed to defining plugin configuration information this way :+1:

Will need to run through an actual test with an SSO provider just to be sure, before merging.

@barisusakli no, actually. I didn't know they existed. Feel free to revert mine and use yours. Or just close this PR 👍

Our existing service worker configuration only exists so that you can install the app onto your home screen. It doesn't actually do anything, but we also don't have much expertise...

> Is there a way to disable it from the ACP ? I couldn't see anything obvious. No, unfortunately not. Right now the service worker is just loaded via the...

Correction, `registerServiceWorker` is called in `app.js` on load. Should be trivial to put this behind a feature flag.

As an aside, the reason why the page works fine on Safari is because `registerServiceWorker` checks for iOS devices and does nothing... so it seems.

I hate to be a "blame the bigger org", but the situation as I understand it seems to be; * The service worker implementation was working fine for all browsers...