Julian Lam

Results 132 comments of Julian Lam

Hi @stevefan1999-personal -- is there a specific reason you've updated the Dockerfile to use these configurations?

Right, and the choice between Debian Buster and Alpine...? You should not bundle imagemagick in the file, as it is not required by NodeBB unless you are using the imagemagick...

Thanks for the explanation. The change to use yarn is certainly ok, although I think some flag needs to be set in NodeBB setup, I will review again later today.

@nilsramsperger this is an unsolicited plea for a second pair of eyes on this PR 😁

@stevefan1999-personal Let's keep it simple and revert back to npm. I am okay if you want to switch to Alpine Linux since @nilsramsperger is using it. If you need imagemagick...

@nilsramsperger Can you kindly do a test run and let us know if there are any unexpected behaviours with this new image?

Acceptable loss, fine to leave out. You can also leave out the older formats, we haven't supported those browsers in quite awhile now, so anyone trying to use NodeBB from...

Did the font styles change? If not, then it seems like this doesn't contain any breaking changes (besides the two minor ones which I am intentionally going to overlook)

Ah, if there is an actual visual distinction, then we will merge this in on a v3 branch.