Justin Flannery

Results 33 comments of Justin Flannery

Exciting! I'll get a look at this soon. Thank you for the contribution

Until I find a better solution, will you also bump the version @ `camply/_version.py` too?

Hey @matthazinski last follow up here - I tidied up some of the linting errors and pushed this to main. Thank you very much for the contribution!

Hey @alexblanck - It's definitely on my [radar](https://juftin.com/blog/lets-talk-about-camply/#camply-feature-ideas-and-tech-debt). There's also a preexisting discussion surrounding permits here: https://github.com/juftin/camply/discussions/22 Currently the big obstacle to implementing this is finding a standardized way to...

Oh very nice. Here's a very rough guide for implementing a new "Provider" with `camply`: 1) Implement a new `BaseCampingSearch ` class: https://github.com/juftin/camply/blob/7b64c22994d4c9472317230b59b98da98eb224b9/camply/search/base_search.py#L44 - The `BaseCampingSearch` super class handles the...

Another note on how I parse results from the API: I use a custom `pydantic.BaseModel` class (`CamplyModel`) all over `camply` - it's a hashable data container class that defines core...

Hey @stjohnjohnson apologies for the late reply here, I'm just getting back into things after a camping trip actually. I've been digging into this more and here's what I've found:...

Okay, following up. I've been working on it over here and I'm close: https://github.com/juftin/camply/pull/88 The trickiest part has been modifying how the underlying Data Containers handle hashing when some of...

Okay @stjohnjohnson I've made a ton of progress on this and just pushed the latest feature, the `--equipment` flag. Read more about it here: https://juftin.com/camply/README.html#searching-for-a-campsite-that-fits-your-equipment As part of this I've...

@stjohnjohnson one more follow up. Will you test the Telegram notifications for me on `camply 0.4.2`? I tried to standardize notifications but haven't been able to test that Telegram notifications...