Jean-Thierry Kéchichian

Results 106 comments of Jean-Thierry Kéchichian

@hishamco Yes I thought about it but opted to just do what the other tenants actions do, but still added more detailled notification/logging messages if an error occurs.

@agriffard Yes as said to @hishamco for now I opted to do as for other tenant actions, but I'm open to any suggestion. I will add a success notification to...

@sebastienros Maybe not that cyclic dependencies would be a technical concern, but yes to keep things well modularized. @Skrypt I will think about it, no closed opinion, personnaly for now...

@Skrypt @Piedone @lampersky About the `Query` abstraction concern. Maybe metadata, marker interfaces, virtual methods. For example with a new virtual method to not break existing json settings. In the base...

@CrestApps love `OrdinalIgnoreCase` ;) Yes, as we did for tenant/shell names, okay no problem if we don't allow to create "duplicate" that only differ by case, which is the case...

We now target only one framework but was not the case before, try to also add `-f net6.0` to the dotnet publish command because it also build the app first.

Yes this is the kind of things I thought about but let it as is to not change an existing behavior. Otherwise yes, there are certainly some places where it...

About `IsDefaultShell()` in ShellSettings that was before in internal methods defined as needed in a given context which doesn't mean these methods were originally done in the best way and...

Not sure it's a good thing, normally to validate/register things relying on a feature we have the manifest dependencies and the usage of the `[Features()]` attrubute. Or we have the...

I don't think we have an extension point allowing features to collaborate to this admin zone/section, as we do to shape compose a content item with drivers, but also as...