Jean-Thierry Kéchichian

Results 106 comments of Jean-Thierry Kéchichian

Yes, not sure is good to rely on this. Another solution if we also want OC.Resources to not be aware of ISiteService at all, still always register it and then...

Looks like to be a good option, a documented OCBuilder extension allowing to configure OC.Resources options at the tenant level, this when the goal is to use OC.Resources but without...

@CrestApps Yes about the `OC.Settings` pattern as said > Not sure I like this pattern but this is what is currently done in OC.Security. The problem is that I started...

Okay no problem, as you want ;) Yes no clear direction exists yet that's why we need discussions, but whatever the solution it should be as well as possible. So...

Okay thank you for your patience Just saw that you still have `ResourceConfigureOptions : IConfigureOptions` in OC.Settings, was not sure. So with my last suggestion you would just have to...

@CrestApps Looks good, I will review it this night. About your question I let you a comment on gitter, let me know if I was not clear.

Fixed by https://github.com/OrchardCMS/OrchardCore/pull/12729

Here the "concern" is the usage by design of our coded `TimeSpan` shape https://github.com/OrchardCMS/OrchardCore/blob/c255456bf1d9093d13447e17485a23a1253f3e9b/src/OrchardCore/OrchardCore.DisplayManagement/Shapes/DateTimeShapes.cs#L35-L46 @hyzx86 would prefer the usage of our `DateTime` shape whose code looks like his suggestion ;)...

Yes you are right, I asked to do it like this for the `Media.AmazonS3` module, if you look at the comments of the related merged PR. But we didn't update...

With the `OrchardCore.Tenants.Distributed` feature, need to be updated too, then it will detect that the shell settings collection has changed, as we already do for newly created tenants. Only one...