Julian Tescher

Results 75 comments of Julian Tescher

Rust currently has code coverage as well as automated docs deployment

Noticed this as well. Is there something stopping this PR from being merged?

Not sure that there is a great way of doing this currently, you can manually get an otel context from tracing via [Span::current().context()](https://docs.rs/tracing-opentelemetry/0.15.0/tracing_opentelemetry/trait.OpenTelemetrySpanExt.html#tymethod.context) and then get the id via [context.span().span_context().trace_id()](https://docs.rs/opentelemetry/0.16.0/opentelemetry/trace/trait.TraceContextExt.html#tymethod.span),...

Hm I can't actually reproduce the behavior. Both the code in the description and cloning and running https://github.com/clux/tracing-otlp-test/blob/master/blah.rs seem to run and exit normally. @clux anything specific needed to show...

Oh I see the issue now (hadn't bound the ports properly when starting the otlp docker container was my issue). So this looks like the issue is this configuration is...

probably not bench, but fmt clippy and test, could have a script that calls the other two current scripts and runs `cargo fmt`

Ideally this would run `cargo test` to run with the default features, and `cargo test --all-features` to run tests with all the features set (the full feature matrix is probably...

I think this could likely be accomplished with something as simple as `$ cargo fmt && ./scripts/lint.sh && ./scripts/test.sh`

@hdost want some help making the last changes? Think this is the only blocker to releasing v0.18

> @jtescher @TommyCpp what are your thoughts? I'm in favor of going to 1.56 and 2021 edition 👍