Perform sampling as explained in the specification.

[hdost]

• Sampling should always defer to the existing sampler. The logic before this patch reflected something similar to what is described in the ParentBased sampler.

Relates #800

[codecov[bot]]

Codecov Report

Base: 66.6% // Head: 66.5% // Decreases project coverage by -0.0% :warning:

Coverage data is based on head (c91f56d) compared to base (ffe1fbb). Patch has no changes to coverable lines.

:exclamation: Current head c91f56d differs from pull request most recent head a0f8e04. Consider uploading reports for the commit a0f8e04 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #839     +/-   ##
=======================================
- Coverage   66.6%   66.5%   -0.1%     
=======================================
  Files        113     113             
  Lines       8798    8712     -86     
=======================================
- Hits        5861    5799     -62     
+ Misses      2937    2913     -24     

Impacted Files	Coverage Δ
opentelemetry-sdk/src/trace/tracer.rs	92.5% <ø> (+1.5%)	:arrow_up:
opentelemetry-jaeger/src/exporter/config/agent.rs	58.0% <0.0%> (-2.6%)	:arrow_down:
...emetry-jaeger/src/exporter/config/collector/mod.rs	56.5% <0.0%> (-1.8%)	:arrow_down:
opentelemetry-sdk/src/testing/trace.rs	69.3% <0.0%> (-1.2%)	:arrow_down:
opentelemetry-api/src/trace/span_context.rs	87.2% <0.0%> (-1.1%)	:arrow_down:
opentelemetry-jaeger/src/lib.rs	93.0% <0.0%> (-0.4%)	:arrow_down:
opentelemetry-aws/src/lib.rs	89.8% <0.0%> (ø)
opentelemetry-jaeger/src/exporter/config/mod.rs	75.5% <0.0%> (ø)
...aeger/src/exporter/config/collector/http_client.rs	22.5% <0.0%> (ø)
...elemetry-sdk/src/metrics/aggregators/last_value.rs	46.2% <0.0%> (+0.8%)	:arrow_up:
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[jtescher]

@hdost want some help making the last changes? Think this is the only blocker to releasing v0.18

[hdost]

@hdost want some help making the last changes? Think this is the only blocker to releasing v0.18

I can push out a change tomorrow 👍🏼

[hdost]

Sorry again for the delay on this. All should be good now.

[hdost]

Sorry again for the delay on this. All should be good now.

Unsure why i have an issue with msrv...

[djc]

Because there was a new release of the h2 library recently, and it requires 1.56. I don't think our 1.49 is tenable anymore, we should just bump to 1.56 like the rest of the ecosystem.

[hdost]

Because there was a new release of the h2 library recently, and it requires 1.56. I don't think our 1.49 is tenable anymore, we should just bump to 1.56 like the rest of the ecosystem.

Indeed 😞 @jtescher @TommyCpp what are your thoughts?

[jtescher]

@jtescher @TommyCpp what are your thoughts?

I'm in favor of going to 1.56 and 2021 edition 👍

[TommyCpp]

Agreed. I think tracing also have a PR to bump the MSRV too

[hdost]

Agreed. I think tracing also have a PR to bump the MSRV too

It appears so though it's been open for a month i feel they probably will. , should we open a separate PR for MSRV increase?

[djc]

See #866.

[hdost]

😢

error: package `async-global-executor v2.3.0` cannot be built because it requires rustc 1.59 or newer, while the currently active rustc version is 1.56.1

[jtescher]

@hdost if you merge main you'll pick up the script changes to get MSRV passing again

[hdost]

Finally! 👍🏼 Things are passing

[jtescher]

@hdost if you want to become an approver (requirements) I'm happy to sponsor you, just have open an issue here to get added.

[TommyCpp]

@hdost if you want to become an approver (requirements) I'm happy to sponsor you, just have open an issue here to get added.

+1 if you need another sponsor I can help. Again thanks for all the work on the sampling side!