Jacob Bandes-Storch

Results 243 comments of Jacob Bandes-Storch

The plain `media="..."` approach won't work for us because the user is able to override the system setting by manually selecting light or dark mode in settings. However, it sounds...

What message types are used to visualize the octomap? Please provide some more information about the data and examples we can look at. > Currently map panel only displays is...

Our rosbridge connection feature uses [roslibjs](https://github.com/RobotWebTools/roslibjs) under the hood, so that would be the place where this needs to be implemented. I would recommend filing an issue in that repo...

Note that the "bad magic" that studio complains about is located _near_ the end of the file. And it seems like the file does not end with the expected trailing...

Oh yeah, you're right it does. I was just looking near the end because I wanted to see the trailing magic.

With https://github.com/foxglove/studio/pull/4325 we have changed the default so that links will open in the web app without a prompt. If you still need an override, you can set the `openIn`...

@geetesh which nav_msgs are you most in need of?

Thanks for the suggestion. But this seems to break [`pipenv install`](https://github.com/foxglove/mcap/runs/5874135680?check_suite_focus=true): ``` pipenv.patched.notpip._internal.exceptions.InstallationError: File "setup.py" or "setup.cfg" not found. Directory cannot be installed in editable mode: /home/runner/work/mcap/mcap/python (A "pyproject.toml" file...

Based on [this issue](https://github.com/pypa/flit/issues/466) I wonder if simply upgrading `pip` would be enough to make this work. Could you try upgrading the pip version, or enabling [allow edits from maintainers](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork)...

It looks like there is a pipenv issue tracking this error (ability to install pyproject.toml-only projects as editable): https://github.com/pypa/pipenv/issues/4375 It doesn't seem like there is a strong reason to switch...