Jesse Szwedko

Yeah, that is an unfortunate gap. I do see some discussion around that in https://github.com/BurntSushi/ripgrep/pull/765 From there I found a link to https://github.com/gilnaa/globwalk which might be another candidate. More discussion...

Thanks for reviewing @bruceg . I realize I completely forgot about Windows here so I'll need to rework this a bit to abstract the signaling bits. I'll move this back...

> Moreover.. who cares about Windows? 🤯 If it's problematic to support Windows API right away, why not to merge this to fix 99,9% use-cases and add Windows support later?...

Moving this out of draft as I implemented non-graceful shutdown for Windows processes (to be improved later).

> I have a couple of suggestions below. I am also wondering if this will fail to terminate subprocesses that don't respond to the signal on Unix. That is, if...

@fanatid I think we should just make sure to satisfy the requirements of the license. In this case, given we _are_ redistributing the source including the licenses with the code...

cc/ @binarylogic

After talking with Luke and Ana a bit, it seems like we are particularly interested in testing out specifically high cardinality and low cardinality events with transforms.

> @jszwedko Ping ! Apologies for the delay! We'll get this reviewed next week. The changes look straight-forward enough.

Hi @sproberts92 ! Is this ready for re-review? Feel free to tag when it is.