Jesse Szwedko

Noting a user did do a POC of this: > I'm working on a POC with Vector running it within AWS Lambda. I managed to run Vector as an [extension](https://docs.aws.amazon.com/lambda/latest/dg/runtimes-extensions-api.html)...

I also have a question about this. We were using: ``` crc::crc64::checksum_ecma(&buf[..]) ``` It _seems_ like this should be replace by: ``` Crc::::new(&crc::CRC_64_ECMA_182).checksum(&buf[..]) ``` But this is calculating a different...

Aha, yep, that appears to be it. Thanks @akhilles !

:+1: thanks for the report @nicklaw5 It looks like the [`ResponseWriter.WriteHeader()`](https://github.com/urfave/negroni/blob/master/recovery.go#L156) call flushes, disallowing any additional header setting. My initial thought is to move that call into the default `PanicFormatter`...

:+1: agreed; I think that should be feasible by passing in a different `ResponseWriter` that would do something akin to https://github.com/urfave/negroni/blob/master/response_writer.go#L56-L64. I'll try to get to this, but PRs also...

Hi @CarterScadden It looks like the there is a null pointer being dereferenced at `github.com/direcotry/directory2/models.(*Pdb).Message(0x9aa960, 0xc0002b3a40, 0x8, 0x2, 0x2, 0x11, 0x0, 0x0, 0xc000099648) /home/user/go/src/github.com/direcotry/directory2/models/models.go:53 +0xa4`. I might suggest tracing the...

Hi @rayjlinden can you provide some more details or example code demonstrating the issue? There is a `negroni.ResonseWriter` struct that you can use to wrap the middleware: https://github.com/urfave/negroni/blob/master/response_writer.go#L31

Hi @DenisKuplyakov ! That is a good observation. It looks like `prometheus/client_golang`'s approach would be workable. I'd happily see a PR for adding that here.

@pjebs looks like there are some race conditions introduced by this. I'd still like to see some benchmarks motivating this change, but I can plan on running some after the...

@pjebs I'm unable to reproduce on master, but am able to consistently reproduce given your patch. Given that you are adding an additional goroutine, I don't think it is too...