fix(exec source): Fix graceful shutdown behavior

Open jszwedko opened this issue 3 years ago • 8 comments

Previously, the exec source would abort whenever Vector was shutting down but this is unexpected behavior. The expected behavior is that the exec source will wait for its subprocess to exit.

In addition, to support this behavior, a SIGTERM is sent to the child process when Vector starts shutting down so that the subprocess can handle this and gracefully shutdown.

Fixes: #11884

Signed-off-by: Jesse Szwedko [email protected]

Mar 18 '22 18:03 jszwedko

Deploy Preview for vector-project ready!

Name	Link
Latest commit	634d9107b69d141273f169de0366c4605468bb3b
Latest deploy log	https://app.netlify.com/sites/vector-project/deploys/62f65580f13bf50008418cf6
Deploy Preview	https://deploy-preview-11907--vector-project.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Mar 18 '22 18:03 netlify[bot]

Soak Test Results

Baseline: c684f408eadc3ff7a3a7e86c90b2378cad28c3bd Comparison: b016c6b201f1d2496d83c61d5c36a471467bf233 Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±5%:

Fine details of change detection per experiment.

experiment	Δ mean	Δ mean %	confidence	baseline mean	baseline stdev	baseline stderr	baseline CoV	comparison mean	comparison stdev	comparison stderr	comparison CoV	erratic	declared erratic
socket_to_socket_blackhole	1.05MiB	4.07	100.00%	25.84MiB	162.21KiB	6.59KiB	0.00612622	26.89MiB	279.09KiB	11.07KiB	0.0101292	False	False
http_pipelines_blackhole_acks	16.2KiB	2.59	45.49%	625.96KiB	448.95KiB	18.45KiB	0.716605	642.16KiB	469.52KiB	19.4KiB	0.730531	True	True
datadog_agent_remap_blackhole	1.14MiB	2.55	100.00%	44.63MiB	1000.03KiB	40.62KiB	0.0218641	45.77MiB	882.1KiB	35.92KiB	0.0188069	False	False
datadog_agent_remap_datadog_logs	1.39MiB	2.16	100.00%	64.28MiB	965.53KiB	39.22KiB	0.0146565	65.67MiB	1.48MiB	61.87KiB	0.0225178	False	False
http_to_http_json	418.32KiB	2.05	100.00%	19.96MiB	793.91KiB	32.2KiB	0.0388125	20.37MiB	833.18KiB	33.01KiB	0.039917	False	False
syslog_regex_logs2metric_ddmetrics	140.46KiB	1.17	99.97%	11.68MiB	834.21KiB	38.2KiB	0.0696634	11.82MiB	191.88KiB	7.83KiB	0.0158413	False	False
datadog_agent_remap_datadog_logs_acks	672.08KiB	1.03	100.00%	63.71MiB	1.1MiB	45.74KiB	0.0172897	64.36MiB	1.15MiB	47.75KiB	0.017819	False	False
syslog_humio_logs	169.76KiB	1.02	99.27%	16.3MiB	1.35MiB	62.6KiB	0.0824913	16.47MiB	170.99KiB	6.91KiB	0.0101303	False	False
syslog_log2metric_splunk_hec_metrics	160.78KiB	0.95	99.55%	16.45MiB	244.46KiB	9.73KiB	0.0145016	16.61MiB	1.18MiB	55.44KiB	0.0712819	False	False
http_pipelines_blackhole	4.53KiB	0.71	13.39%	634.1KiB	442.9KiB	18.33KiB	0.697876	638.63KiB	476.9KiB	19.65KiB	0.746116	True	True
syslog_loki	23.23KiB	0.18	30.42%	12.58MiB	1.21MiB	56.26KiB	0.0957686	12.6MiB	414.66KiB	19.01KiB	0.0320921	False	False
splunk_hec_to_splunk_hec_logs_noack	1.58KiB	0.01	6.64%	23.84MiB	338.74KiB	13.83KiB	0.0138653	23.84MiB	321.82KiB	13.01KiB	0.0131722	False	False
splunk_hec_to_splunk_hec_logs_acks	796.63B	0	2.33%	23.84MiB	439.63KiB	17.95KiB	0.0179917	23.84MiB	484.2KiB	19.62KiB	0.0198156	False	False
splunk_hec_indexer_ack_blackhole	-556.16B	-0	2.31%	23.84MiB	328.07KiB	13.28KiB	0.0134259	23.84MiB	324.81KiB	13.26KiB	0.0132929	False	False
fluent_elasticsearch	-8.79KiB	-0.01	65.99%	79.47MiB	55.12KiB	2.23KiB	0.000676779	79.46MiB	220.89KiB	8.93KiB	0.00271239	False	False
http_to_http_noack	-1.42KiB	-0.01	7.23%	23.84MiB	261.46KiB	10.56KiB	0.0107011	23.84MiB	285.71KiB	11.54KiB	0.0116943	False	False
datadog_agent_remap_blackhole_acks	-73.72KiB	-0.16	64.13%	44.54MiB	1.49MiB	62.27KiB	0.0334147	44.47MiB	1.21MiB	50.69KiB	0.027245	False	False
http_datadog_filter_blackhole	-29.25KiB	-0.46	55.96%	6.17MiB	622.15KiB	25.27KiB	0.0983361	6.14MiB	693.41KiB	28.24KiB	0.110108	False	True
splunk_transforms_splunk3	-74.3KiB	-0.77	52.87%	9.46MiB	1.77MiB	73.42KiB	0.186809	9.39MiB	1.74MiB	72.41KiB	0.185201	False	False
syslog_splunk_hec_logs	-132.41KiB	-0.8	100.00%	16.24MiB	157.65KiB	6.37KiB	0.0094702	16.11MiB	160.71KiB	6.38KiB	0.00973191	False	False
splunk_hec_route_s3	-158.42KiB	-1.09	79.09%	14.22MiB	2.1MiB	86.73KiB	0.147209	14.07MiB	2.21MiB	91.5KiB	0.157005	False	False
fluent_remap_aws_firehose	-1.11MiB	-1.4	99.34%	79.47MiB	54.42KiB	2.21KiB	0.000668151	78.36MiB	9.07MiB	416.55KiB	0.115609	False	False
http_pipelines_no_grok_blackhole	-103.52KiB	-1.72	99.61%	5.88MiB	629.02KiB	25.57KiB	0.104436	5.78MiB	614.08KiB	25.07KiB	0.10374	False	False
http_to_http_acks	-339.91KiB	-1.87	51.98%	17.8MiB	8.2MiB	342.9KiB	0.460522	17.46MiB	8.33MiB	337.84KiB	0.476412	True	True
syslog_log2metric_humio_metrics	-336.01KiB	-2.53	99.99%	12.99MiB	1.48MiB	69.03KiB	0.114144	12.66MiB	1.06MiB	49.6KiB	0.0836302	False	False

Fine details of each soak run.

(experiment, variant, run_id)	total samples	mean	std	min	median	p90	p95	p99	max	skewness
('fluent_remap_aws_firehose', 'baseline', '57d97c97-fd9b-4665-9b08-98d098d47363')	203	79.47MiB	54.65KiB	79.34MiB	79.47MiB	79.54MiB	79.57MiB	79.59MiB	79.62MiB	0.0555367
('fluent_elasticsearch', 'comparison', '6be2d79e-0b38-48ab-b4ba-278f55dff08b')	204	79.47MiB	54.74KiB	79.33MiB	79.47MiB	79.55MiB	79.56MiB	79.58MiB	79.58MiB	-0.0288079
('fluent_remap_aws_firehose', 'comparison', '8f216848-d627-42b6-b575-79310637819d')	202	79.47MiB	55.51KiB	79.36MiB	79.47MiB	79.55MiB	79.57MiB	79.59MiB	79.6MiB	0.217854
('fluent_elasticsearch', 'comparison', 'def5bcf9-fac4-4015-a128-e1eed20d2647')	204	79.47MiB	48.84KiB	79.34MiB	79.47MiB	79.54MiB	79.55MiB	79.58MiB	79.6MiB	-0.0342282
('fluent_remap_aws_firehose', 'baseline', '3e4fd062-d930-4bc1-b8e7-d8751123db52')	202	79.47MiB	50.73KiB	79.34MiB	79.47MiB	79.54MiB	79.56MiB	79.58MiB	79.59MiB	-0.012425
('fluent_remap_aws_firehose', 'comparison', '34602cd9-d417-4063-a79e-3af974e449f1')	202	79.47MiB	53.22KiB	79.35MiB	79.47MiB	79.55MiB	79.56MiB	79.58MiB	79.59MiB	0.0259348
('fluent_elasticsearch', 'baseline', '2aab14fc-ee7e-424b-86d1-f61fd65a99ea')	204	79.47MiB	53.22KiB	79.34MiB	79.47MiB	79.54MiB	79.56MiB	79.59MiB	79.59MiB	-0.0421764
('fluent_elasticsearch', 'baseline', '324d6043-3b50-4791-9bd6-7f3a9778efcf')	204	79.47MiB	55.15KiB	79.35MiB	79.47MiB	79.55MiB	79.56MiB	79.59MiB	79.6MiB	0.00387016
('fluent_elasticsearch', 'baseline', 'e11386be-cbac-45d1-94b7-c9304b3938f1')	204	79.47MiB	57.2KiB	79.35MiB	79.47MiB	79.55MiB	79.57MiB	79.59MiB	79.59MiB	0.00777038
('fluent_remap_aws_firehose', 'baseline', 'aa1d7a9c-0203-4d4d-949c-02ce7b8d5848')	202	79.47MiB	57.87KiB	79.32MiB	79.47MiB	79.55MiB	79.57MiB	79.59MiB	79.61MiB	0.154218
('fluent_elasticsearch', 'comparison', '48dd541d-cf9a-4e22-ab07-03f3800beae8')	204	79.45MiB	375.45KiB	74.3MiB	79.47MiB	79.54MiB	79.57MiB	79.59MiB	79.62MiB	-13.7729
('fluent_remap_aws_firehose', 'comparison', '4fc1846b-73be-4564-b6b0-b715cf478d87')	93	73.54MiB	20.36MiB	62.94KiB	79.47MiB	79.55MiB	79.56MiB	79.58MiB	79.59MiB	-3.28679
('datadog_agent_remap_datadog_logs', 'comparison', 'a43462d2-9ebe-4368-b3f1-93f157c4e2aa')	200	66.85MiB	1.12MiB	65.65MiB	66.21MiB	68.69MiB	68.91MiB	69.14MiB	69.36MiB	0.869906
('datadog_agent_remap_datadog_logs', 'comparison', '69bc9d0a-bb3f-4dc9-80bf-0458be5b9e05')	200	66.1MiB	924.77KiB	64.57MiB	65.81MiB	67.39MiB	67.99MiB	68.62MiB	68.7MiB	1.06331
('datadog_agent_remap_datadog_logs', 'baseline', '05286c73-5c81-4230-899c-a3474f78e14a')	200	65.1MiB	429.52KiB	64.45MiB	64.95MiB	65.79MiB	65.96MiB	66.26MiB	66.31MiB	1.11816
('datadog_agent_remap_datadog_logs_acks', 'comparison', '62d7e101-c902-4eac-978d-730dff55694e')	202	65.08MiB	537.78KiB	64.28MiB	64.95MiB	66.03MiB	66.17MiB	66.4MiB	66.47MiB	1.12167
('datadog_agent_remap_datadog_logs_acks', 'comparison', '9542789c-4d96-4e2c-b1d4-8652ff0ec9f6')	202	64.91MiB	833.81KiB	63.09MiB	64.59MiB	66.06MiB	66.17MiB	66.49MiB	66.64MiB	0.337569
('datadog_agent_remap_datadog_logs_acks', 'baseline', 'ca109f1d-3ffd-414e-a47d-015cacc84be0')	203	64.33MiB	1.16MiB	62.62MiB	63.87MiB	66.28MiB	66.67MiB	66.99MiB	67.2MiB	1.08159
('datadog_agent_remap_datadog_logs', 'comparison', 'acfa3c41-8e28-443c-8780-8a6ffaa7f675')	200	64.06MiB	597.26KiB	63.22MiB	63.81MiB	64.85MiB	64.93MiB	65.06MiB	65.22MiB	0.284605
('datadog_agent_remap_datadog_logs', 'baseline', 'e151d28a-c22f-497f-a199-4cac0e7ac07a')	206	63.98MiB	950.07KiB	54.59MiB	63.73MiB	64.78MiB	65.58MiB	65.97MiB	66.05MiB	-4.58897
('datadog_agent_remap_datadog_logs_acks', 'baseline', '984bf41e-8f7d-404d-a407-e21c0a1cf4da')	203	63.9MiB	763.59KiB	62.89MiB	63.67MiB	65.45MiB	65.65MiB	65.84MiB	65.93MiB	1.43233
('datadog_agent_remap_datadog_logs', 'baseline', 'c2d73e2e-6228-49f0-bc16-804e771d3cce')	200	63.77MiB	799.57KiB	62.72MiB	63.39MiB	65.1MiB	65.27MiB	65.41MiB	65.53MiB	0.987108
('datadog_agent_remap_datadog_logs_acks', 'comparison', '424b2f8c-ab9a-486c-bada-b4316f5a9249')	202	63.09MiB	769.41KiB	61.86MiB	62.84MiB	63.88MiB	64.31MiB	65.62MiB	65.7MiB	1.41054
('datadog_agent_remap_datadog_logs_acks', 'baseline', '5136c79c-7808-462b-955a-b3d80a3a20d8')	203	62.89MiB	828.4KiB	61.55MiB	62.56MiB	64.27MiB	64.37MiB	64.54MiB	64.66MiB	0.834011
('datadog_agent_remap_blackhole', 'comparison', '78eacb46-24b2-4655-9781-a33ad29d7c73')	201	46.37MiB	616.25KiB	45.21MiB	46.32MiB	47.11MiB	47.47MiB	48.11MiB	48.24MiB	0.66187
('datadog_agent_remap_blackhole_acks', 'baseline', 'a8e892d3-764f-4c03-a7e9-567f45d74ea3')	200	45.77MiB	948.05KiB	43.82MiB	45.48MiB	47.08MiB	47.5MiB	47.87MiB	48.27MiB	0.615058
('datadog_agent_remap_blackhole', 'comparison', '4897f20b-9954-45d9-98c4-25ddb072761c')	201	45.54MiB	678.43KiB	44.17MiB	45.47MiB	46.45MiB	46.71MiB	47.09MiB	47.26MiB	0.364235
('datadog_agent_remap_blackhole_acks', 'comparison', 'c3d34a01-43fe-4531-94bb-b0cc1d22a900')	200	45.54MiB	544.45KiB	44.53MiB	45.5MiB	46.28MiB	46.5MiB	46.73MiB	46.89MiB	0.351031
('datadog_agent_remap_blackhole', 'comparison', '71ac9a6d-c547-4669-b333-7307d18a72a6')	201	45.38MiB	949.92KiB	43.59MiB	45.34MiB	46.66MiB	46.8MiB	47.19MiB	47.62MiB	0.115702
('datadog_agent_remap_blackhole', 'baseline', 'cc6f9a91-3058-43da-8c2a-13bffaeeb6f5')	202	45.25MiB	719.09KiB	43.63MiB	45.2MiB	46.26MiB	46.51MiB	46.89MiB	47.62MiB	0.416969
('datadog_agent_remap_blackhole_acks', 'baseline', '5d9943d7-4d41-4139-b6f4-44f9518202c1')	200	45.05MiB	652.57KiB	43.7MiB	44.93MiB	45.97MiB	46.15MiB	46.48MiB	46.71MiB	0.34524
('datadog_agent_remap_blackhole_acks', 'comparison', '42ce6416-3070-4257-966c-5c7a9e37bdad')	200	44.86MiB	585.35KiB	43.44MiB	44.84MiB	45.61MiB	45.82MiB	46.25MiB	46.28MiB	0.164002
('datadog_agent_remap_blackhole', 'baseline', 'ff7aabe2-bf45-42c6-acdc-084a418b5365')	202	44.64MiB	906.77KiB	43.07MiB	44.48MiB	45.9MiB	46.38MiB	46.8MiB	47.03MiB	0.568794
('datadog_agent_remap_blackhole', 'baseline', '9c8d8497-27ef-4d1d-9e7f-b05c43243c9c')	202	44.01MiB	927.51KiB	42.29MiB	43.78MiB	45.19MiB	45.9MiB	46.71MiB	46.88MiB	0.884555
('datadog_agent_remap_blackhole_acks', 'comparison', 'b5cd598b-c89e-4676-8f76-2c4cd4de7dfa')	200	43.01MiB	620.52KiB	41.2MiB	43.03MiB	43.77MiB	43.99MiB	44.18MiB	44.23MiB	-0.228223
('datadog_agent_remap_blackhole_acks', 'baseline', '8ea0faa6-967a-437e-8063-d44add59a595')	200	42.8MiB	786.17KiB	41.17MiB	42.66MiB	43.76MiB	44.04MiB	45.17MiB	45.79MiB	0.919063
('socket_to_socket_blackhole', 'comparison', 'aace97b8-b1ad-415a-bea9-a2c5b5912b97')	232	27.09MiB	77.94KiB	26.83MiB	27.1MiB	27.18MiB	27.2MiB	27.25MiB	27.29MiB	-0.443553
('socket_to_socket_blackhole', 'comparison', 'badb4565-e48e-4e9d-99e9-41bfe1ac27f1')	202	27.03MiB	91.72KiB	26.73MiB	27.03MiB	27.14MiB	27.17MiB	27.21MiB	27.24MiB	-0.112719
('socket_to_socket_blackhole', 'comparison', 'af82efa6-0b3c-4588-a254-9b5eb4ee6092')	202	26.51MiB	92.9KiB	26.25MiB	26.52MiB	26.62MiB	26.65MiB	26.7MiB	26.75MiB	-0.27731
('socket_to_socket_blackhole', 'baseline', '5ff628fe-16e6-4210-9608-df3f48d9cc68')	202	25.96MiB	96.62KiB	25.61MiB	25.98MiB	26.06MiB	26.09MiB	26.15MiB	26.2MiB	-0.635605
('socket_to_socket_blackhole', 'baseline', '637cbb2b-1622-4a00-bfa4-ff5e3130be6f')	202	25.89MiB	71.28KiB	25.69MiB	25.89MiB	25.98MiB	26.0MiB	26.03MiB	26.07MiB	-0.187529
('socket_to_socket_blackhole', 'baseline', 'b1ba0138-7dcd-4fd4-9d43-dfb660bc85d9')	202	25.66MiB	110.23KiB	25.33MiB	25.66MiB	25.79MiB	25.83MiB	25.86MiB	25.92MiB	-0.286835
('splunk_hec_to_splunk_hec_logs_acks', 'baseline', '4fc65744-6d8c-457e-a580-25fb13d1948c')	200	23.85MiB	395.8KiB	22.36MiB	23.84MiB	24.36MiB	24.41MiB	24.6MiB	25.33MiB	-0.0780346
('splunk_hec_indexer_ack_blackhole', 'comparison', '9b54db03-1d1a-4dd4-bde3-42ac4cc4fbcf')	200	23.85MiB	322.95KiB	23.06MiB	23.85MiB	24.24MiB	24.33MiB	24.51MiB	24.6MiB	-0.132432
('splunk_hec_to_splunk_hec_logs_acks', 'comparison', '3c0167b6-83a6-4863-940c-5c90f60e304f')	203	23.85MiB	638.25KiB	21.44MiB	23.84MiB	24.34MiB	24.52MiB	26.16MiB	26.46MiB	-0.0282648
('splunk_hec_to_splunk_hec_logs_acks', 'comparison', '49c16844-5886-4966-a538-37a62347e665')	203	23.85MiB	366.99KiB	22.56MiB	23.87MiB	24.28MiB	24.39MiB	24.6MiB	24.79MiB	-0.311073
('http_to_http_noack', 'comparison', 'd6c54494-4d17-4a3e-9ae5-4501a7b45f2e')	204	23.85MiB	258.7KiB	23.26MiB	23.83MiB	24.19MiB	24.23MiB	24.35MiB	24.78MiB	0.0998003
('http_to_http_noack', 'comparison', 'a0a06160-ca02-41b6-b778-d244c0399f31')	204	23.85MiB	259.68KiB	23.26MiB	23.84MiB	24.16MiB	24.24MiB	24.35MiB	24.78MiB	0.0989364
('http_to_http_noack', 'baseline', 'dafe55b3-0361-41fc-a6a0-27f3113e3bfc')	204	23.85MiB	249.38KiB	23.16MiB	23.84MiB	24.14MiB	24.22MiB	24.36MiB	24.39MiB	-0.146936
('splunk_hec_indexer_ack_blackhole', 'baseline', 'd12945ac-2cb1-4263-966a-5e2cdb22ce61')	205	23.84MiB	334.18KiB	23.06MiB	23.84MiB	24.26MiB	24.34MiB	24.52MiB	24.61MiB	-0.104179
('splunk_hec_indexer_ack_blackhole', 'baseline', 'e6620cf7-c118-4053-8db1-601a1bfa6fce')	200	23.84MiB	330.4KiB	23.06MiB	23.84MiB	24.26MiB	24.37MiB	24.52MiB	24.6MiB	-0.0604105
('http_to_http_noack', 'baseline', 'e9558bcd-1b8f-439b-8adc-9a0b278850de')	204	23.84MiB	251.71KiB	23.29MiB	23.83MiB	24.16MiB	24.23MiB	24.38MiB	24.45MiB	0.000914844
('splunk_hec_to_splunk_hec_logs_noack', 'baseline', '019fbbf8-1658-423e-8b4b-fcbea0e5386b')	200	23.84MiB	343.61KiB	22.91MiB	23.85MiB	24.27MiB	24.45MiB	24.52MiB	24.64MiB	-0.031204
('splunk_hec_indexer_ack_blackhole', 'comparison', '7192f5d3-8f90-4610-9ce4-0697ab1099b3')	200	23.84MiB	326.5KiB	23.06MiB	23.84MiB	24.24MiB	24.37MiB	24.45MiB	24.6MiB	-0.123633
('splunk_hec_to_splunk_hec_logs_noack', 'comparison', 'c2b5ccbd-1009-4929-9e69-f8caddd319e6')	204	23.84MiB	329.81KiB	22.91MiB	23.85MiB	24.22MiB	24.37MiB	24.51MiB	24.6MiB	-0.144338
('splunk_hec_to_splunk_hec_logs_noack', 'comparison', '659437aa-abc3-4c14-b0d9-1ca6a60f0ab8')	204	23.84MiB	318.94KiB	23.06MiB	23.84MiB	24.22MiB	24.35MiB	24.57MiB	24.6MiB	-0.0257418
('splunk_hec_to_splunk_hec_logs_noack', 'baseline', '4da53aa3-7a2e-4c4b-8b57-14da9eb74862')	200	23.84MiB	322.49KiB	22.94MiB	23.84MiB	24.26MiB	24.37MiB	24.45MiB	24.6MiB	-0.086577
('splunk_hec_to_splunk_hec_logs_acks', 'baseline', '28019960-e39a-406c-aa93-81f232caad44')	200	23.84MiB	494.13KiB	21.62MiB	23.84MiB	24.29MiB	24.51MiB	25.57MiB	25.95MiB	0.0583792
('splunk_hec_indexer_ack_blackhole', 'baseline', '02ba2cde-19f8-49e1-aecb-6ce9e24271d4')	205	23.84MiB	321.12KiB	23.06MiB	23.85MiB	24.2MiB	24.33MiB	24.52MiB	24.6MiB	-0.135871
('splunk_hec_to_splunk_hec_logs_acks', 'baseline', 'fad921cf-9c7b-4d3d-bcc8-133c6f33132d')	200	23.84MiB	425.29KiB	22.71MiB	23.84MiB	24.33MiB	24.52MiB	24.93MiB	25.09MiB	0.14404
('splunk_hec_to_splunk_hec_logs_noack', 'comparison', '1ea4f310-f1a2-4791-ad4d-6d7022d7f0f9')	204	23.84MiB	318.15KiB	23.06MiB	23.84MiB	24.22MiB	24.3MiB	24.58MiB	24.64MiB	-0.0657892
('splunk_hec_indexer_ack_blackhole', 'comparison', '7eb3f611-7e5f-4694-b999-9b101b84826c')	200	23.84MiB	326.51KiB	22.97MiB	23.87MiB	24.22MiB	24.29MiB	24.48MiB	24.6MiB	-0.268332
('splunk_hec_to_splunk_hec_logs_acks', 'comparison', 'dd0f66c9-adb0-4743-8ece-1d84fa39e051')	203	23.84MiB	404.4KiB	22.62MiB	23.84MiB	24.33MiB	24.46MiB	24.88MiB	25.37MiB	0.137871
('http_to_http_noack', 'baseline', '2b480003-6aac-461d-9ce4-f615a985c1c2')	205	23.83MiB	282.93KiB	22.34MiB	23.83MiB	24.2MiB	24.28MiB	24.37MiB	24.45MiB	-0.726473
('splunk_hec_to_splunk_hec_logs_noack', 'baseline', '514a7514-9063-4abd-a5fd-d53f66cfd333')	200	23.83MiB	351.09KiB	22.38MiB	23.85MiB	24.24MiB	24.39MiB	24.57MiB	24.64MiB	-0.450211
('http_to_http_noack', 'comparison', '078f9968-5bee-4515-adcf-7e3b7f269b5b')	205	23.82MiB	332.94KiB	20.7MiB	23.83MiB	24.14MiB	24.23MiB	24.34MiB	24.35MiB	-4.37087
('http_to_http_json', 'comparison', 'e6477c40-df9c-4a6a-8eea-f2e37980f207')	229	20.58MiB	791.05KiB	18.95MiB	20.58MiB	21.55MiB	21.95MiB	22.42MiB	23.16MiB	0.257229
('http_to_http_json', 'comparison', '77083143-d29f-41da-879f-8c47be0095c4')	204	20.33MiB	687.76KiB	18.59MiB	20.27MiB	21.11MiB	21.39MiB	22.05MiB	22.8MiB	0.286798
('http_to_http_json', 'comparison', 'bd3c56aa-c04f-47d4-b7eb-4d5c67eb7c25')	204	20.17MiB	951.23KiB	17.56MiB	20.18MiB	21.32MiB	21.56MiB	21.9MiB	22.56MiB	-0.333336
('http_to_http_json', 'baseline', '9885904c-1ac5-474b-8581-eb622fd8e6ee')	204	20.1MiB	883.5KiB	17.49MiB	20.11MiB	21.23MiB	21.43MiB	21.8MiB	22.38MiB	-0.174843
('http_to_http_json', 'baseline', 'e76b83fd-724c-4b95-af66-a078733edc30')	204	19.98MiB	695.53KiB	17.63MiB	20.02MiB	20.81MiB	21.0MiB	21.55MiB	21.79MiB	-0.11213
('http_to_http_json', 'baseline', '56422b8a-7120-4d6b-9bc2-90a9b8b3a300')	200	19.79MiB	761.41KiB	17.74MiB	19.77MiB	20.61MiB	20.87MiB	21.72MiB	22.25MiB	-0.00019045
('http_to_http_acks', 'baseline', '201a766f-ddbb-4509-aa04-67134b0872a9')	200	18.13MiB	8.35MiB	2.92MiB	19.87MiB	29.33MiB	30.61MiB	30.84MiB	40.12MiB	-0.163743
('http_to_http_acks', 'comparison', '28d88b98-a2bc-4d18-bf71-d0ea7ec872d8')	204	17.92MiB	7.87MiB	2.17MiB	18.95MiB	28.01MiB	30.49MiB	30.62MiB	30.81MiB	-0.28138
('http_to_http_acks', 'baseline', '3491abe1-6b92-491c-87a6-e433eee6c995')	200	17.63MiB	8.14MiB	1.58MiB	18.76MiB	28.51MiB	30.49MiB	30.72MiB	30.81MiB	-0.216152
('http_to_http_acks', 'baseline', '5bfddd14-584c-4f28-b1aa-cf19aa7b7c5e')	200	17.63MiB	8.15MiB	1006.35KiB	18.77MiB	28.68MiB	30.49MiB	30.75MiB	30.81MiB	-0.156516
('http_to_http_acks', 'comparison', '4603e07d-7bec-42ae-8192-65d2bc1372b9')	204	17.46MiB	8.51MiB	1.01MiB	18.68MiB	29.37MiB	30.49MiB	30.72MiB	35.18MiB	-0.178572
('http_to_http_acks', 'comparison', 'e32f8136-4763-470f-8083-e4dbd22db508')	229	17.06MiB	8.57MiB	2.32MiB	18.79MiB	27.32MiB	30.25MiB	30.68MiB	30.74MiB	-0.188557
('syslog_humio_logs', 'baseline', '81d6d190-f505-4b27-9924-cc1a57ea870e')	202	16.75MiB	95.34KiB	16.47MiB	16.74MiB	16.9MiB	16.93MiB	16.99MiB	17.0MiB	0.680199
('syslog_log2metric_splunk_hec_metrics', 'comparison', 'be00cccb-dcb7-4308-a83f-efb9449db3a6')	200	16.74MiB	170.45KiB	16.48MiB	16.78MiB	16.94MiB	16.96MiB	16.98MiB	17.01MiB	-0.0303468
('syslog_humio_logs', 'comparison', '3b87e437-df00-493b-8112-e83647020e3e')	204	16.57MiB	235.54KiB	16.28MiB	16.44MiB	16.91MiB	16.94MiB	17.01MiB	17.06MiB	0.602681
('syslog_log2metric_splunk_hec_metrics', 'baseline', 'ddf14bc9-0094-4679-9c15-616d6b564514')	231	16.56MiB	282.64KiB	16.06MiB	16.43MiB	17.0MiB	17.05MiB	17.14MiB	17.19MiB	0.544621
('syslog_log2metric_splunk_hec_metrics', 'comparison', 'a61abac5-aadf-42e9-8941-b64451f2c8a1')	200	16.56MiB	187.66KiB	16.31MiB	16.48MiB	16.84MiB	16.88MiB	16.91MiB	16.91MiB	0.585535
('syslog_log2metric_splunk_hec_metrics', 'baseline', '0bb48579-674d-495b-9522-1421fd0c6ae0')	200	16.54MiB	40.41KiB	16.39MiB	16.54MiB	16.58MiB	16.59MiB	16.62MiB	16.63MiB	-0.465604
('syslog_humio_logs', 'comparison', 'e487f5e1-3ed3-405c-86ad-c06c9e63af6d')	204	16.44MiB	115.97KiB	16.26MiB	16.4MiB	16.61MiB	16.67MiB	16.72MiB	16.75MiB	0.884285
('syslog_humio_logs', 'comparison', 'bcf687e2-1619-4cb4-ab9e-e5d68713b8d9')	204	16.4MiB	58.98KiB	16.23MiB	16.4MiB	16.47MiB	16.49MiB	16.55MiB	16.66MiB	0.715488
('syslog_log2metric_splunk_hec_metrics', 'comparison', '0324c19e-c573-4adc-a03d-52767711072a')	79	16.39MiB	2.89MiB	50.13KiB	16.99MiB	17.13MiB	17.31MiB	17.42MiB	17.48MiB	-5.20163
('syslog_splunk_hec_logs', 'baseline', '079b8713-e11d-4e61-929d-9c532ced2890')	204	16.35MiB	85.65KiB	16.22MiB	16.33MiB	16.46MiB	16.54MiB	16.64MiB	16.66MiB	1.47722
('syslog_splunk_hec_logs', 'baseline', 'dc56ab10-ffe7-427e-9a5c-8e42fe626fd6')	204	16.27MiB	53.12KiB	16.16MiB	16.28MiB	16.33MiB	16.34MiB	16.44MiB	16.53MiB	0.720069
('syslog_log2metric_splunk_hec_metrics', 'baseline', '9f46abef-5609-455a-9d8a-e1cdf2457fba')	200	16.23MiB	146.1KiB	15.99MiB	16.17MiB	16.42MiB	16.44MiB	16.46MiB	16.49MiB	0.199679
('syslog_humio_logs', 'baseline', '9533ef59-d6c1-4219-877d-1f79c7f20c02')	202	16.21MiB	135.75KiB	16.01MiB	16.16MiB	16.4MiB	16.43MiB	16.5MiB	16.54MiB	0.54277
('syslog_splunk_hec_logs', 'comparison', '9cff8d42-30bb-4b00-b8cc-b30c1c171f41')	200	16.18MiB	85.48KiB	15.99MiB	16.18MiB	16.25MiB	16.32MiB	16.43MiB	16.44MiB	0.36972
('syslog_splunk_hec_logs', 'comparison', '7e72cd1b-e77d-4d4e-8ce9-1d03fe281beb')	234	16.12MiB	225.57KiB	15.64MiB	16.18MiB	16.33MiB	16.47MiB	16.56MiB	16.62MiB	-0.214185
('syslog_splunk_hec_logs', 'baseline', '94bf8766-954e-4212-a36e-aa9b21157def')	204	16.11MiB	178.99KiB	15.76MiB	16.08MiB	16.34MiB	16.37MiB	16.42MiB	16.44MiB	0.180174
('syslog_splunk_hec_logs', 'comparison', 'cfc5b7a1-92e6-4960-bf59-eaae8505b5d3')	200	16.05MiB	82.4KiB	15.83MiB	16.07MiB	16.13MiB	16.14MiB	16.17MiB	16.2MiB	-0.859664
('syslog_humio_logs', 'baseline', '39837f6e-71e1-4911-a1d3-2c5ab35d0cfe')	81	15.43MiB	3.1MiB	25.14KiB	16.07MiB	16.22MiB	16.3MiB	16.46MiB	16.49MiB	-4.61447
('splunk_hec_route_s3', 'comparison', '6ce49413-a81b-46f8-8097-95c1e5703538')	204	14.3MiB	2.17MiB	9.91MiB	14.27MiB	17.15MiB	17.55MiB	18.46MiB	18.8MiB	-0.0427964
('splunk_hec_route_s3', 'baseline', '932db94d-d5b7-4c3b-9bf3-3c3974b18922')	204	14.26MiB	2.17MiB	9.0MiB	14.35MiB	16.91MiB	17.66MiB	18.84MiB	19.32MiB	0.00841709
('splunk_hec_route_s3', 'baseline', '8790aa94-fdb1-458f-9423-d0bc468a33f0')	204	14.22MiB	2.01MiB	9.82MiB	14.24MiB	16.85MiB	17.32MiB	18.1MiB	18.22MiB	-0.0470503
('splunk_hec_route_s3', 'baseline', '54274ace-3ad5-4f85-84ba-cfe7956fbb41')	204	14.18MiB	2.11MiB	9.01MiB	14.21MiB	17.16MiB	17.65MiB	18.1MiB	19.14MiB	-0.0270777
('splunk_hec_route_s3', 'comparison', '27de5930-712c-4879-994d-5e69d461fd3c')	204	14.01MiB	2.33MiB	8.46MiB	14.03MiB	17.25MiB	17.56MiB	19.04MiB	20.08MiB	0.0357465
('splunk_hec_route_s3', 'comparison', '36dfd7cf-9f54-4565-8359-26a9d5221bc2')	204	13.9MiB	2.12MiB	8.46MiB	14.04MiB	16.57MiB	17.18MiB	18.52MiB	20.86MiB	0.133483
('syslog_log2metric_humio_metrics', 'baseline', '3f7c9d0d-fc69-45ed-b067-69d493aa2363')	202	13.21MiB	128.0KiB	12.88MiB	13.2MiB	13.38MiB	13.43MiB	13.47MiB	13.53MiB	0.0751334
('syslog_log2metric_humio_metrics', 'baseline', '0655a4d5-cebd-4d87-9e55-c8ff2a18c0f9')	202	13.17MiB	108.93KiB	12.89MiB	13.16MiB	13.3MiB	13.37MiB	13.46MiB	13.48MiB	0.523225
('syslog_loki', 'baseline', 'be20fca0-d178-47ad-86ad-646dba2421c6')	202	12.82MiB	143.88KiB	12.52MiB	12.81MiB	12.98MiB	13.03MiB	13.15MiB	13.19MiB	0.0705482
('syslog_log2metric_humio_metrics', 'comparison', '97d6c879-0ec7-4242-bef6-3286cdec41b6')	200	12.77MiB	63.93KiB	12.59MiB	12.77MiB	12.85MiB	12.87MiB	12.89MiB	12.96MiB	-0.235929
('syslog_loki', 'comparison', '7536ee4b-8352-4630-8b9d-9291b654bd7c')	200	12.69MiB	236.78KiB	12.24MiB	12.72MiB	13.01MiB	13.06MiB	13.12MiB	13.19MiB	0.0660781
('syslog_loki', 'comparison', '0f8815db-9eaa-4638-947a-92b89e0c3af5')	76	12.67MiB	900.55KiB	5.37MiB	12.81MiB	12.98MiB	13.01MiB	13.08MiB	13.09MiB	-7.84229
('syslog_log2metric_humio_metrics', 'comparison', '3e400321-d1c4-4f11-909a-66d0db940933')	200	12.65MiB	129.8KiB	12.42MiB	12.61MiB	12.81MiB	12.86MiB	12.9MiB	13.02MiB	0.387918
('syslog_loki', 'baseline', '5ad6bad0-922c-4e5b-bd93-f7d4f6f06b5b')	202	12.52MiB	88.07KiB	12.35MiB	12.52MiB	12.62MiB	12.66MiB	12.73MiB	12.84MiB	0.334769
('syslog_loki', 'comparison', 'bb43c5ad-e192-47b0-8f51-4ce0eaa9244e')	200	12.5MiB	168.69KiB	12.22MiB	12.46MiB	12.69MiB	12.9MiB	13.04MiB	13.18MiB	1.71129
('syslog_log2metric_humio_metrics', 'comparison', '19e85a0f-6543-4ae0-9407-60ffe8759c11')	79	12.44MiB	2.6MiB	24.76KiB	13.01MiB	13.16MiB	13.19MiB	13.36MiB	13.49MiB	-4.45043
('syslog_loki', 'baseline', '722b9f2d-15f8-4834-9ea4-47d92dea3cc5')	78	12.12MiB	2.94MiB	12.56KiB	12.85MiB	13.06MiB	13.1MiB	13.13MiB	13.13MiB	-3.81546
('syslog_log2metric_humio_metrics', 'baseline', '042d0076-822d-4682-82d9-84f26d89055e')	81	12.02MiB	3.48MiB	12.37KiB	13.04MiB	13.24MiB	13.28MiB	13.33MiB	13.35MiB	-3.14063
('syslog_regex_logs2metric_ddmetrics', 'comparison', 'e1343ad5-8410-4cbd-8df1-6c2cfea7b985')	200	11.97MiB	187.25KiB	11.62MiB	12.0MiB	12.18MiB	12.21MiB	12.44MiB	12.48MiB	-0.0812071
('syslog_regex_logs2metric_ddmetrics', 'baseline', 'e60bf811-a6df-46f1-b305-04abe051ef8b')	200	11.77MiB	140.6KiB	11.57MiB	11.73MiB	11.92MiB	11.98MiB	12.3MiB	12.35MiB	2.38502
('syslog_regex_logs2metric_ddmetrics', 'comparison', '10a55cd5-5da7-42f5-8b6a-0b452bf381d9')	200	11.76MiB	134.66KiB	11.54MiB	11.73MiB	11.91MiB	12.05MiB	12.19MiB	12.24MiB	1.50832
('syslog_regex_logs2metric_ddmetrics', 'baseline', '867c0ae6-18c4-4e19-a994-e33526f91602')	200	11.75MiB	79.99KiB	11.58MiB	11.73MiB	11.85MiB	11.89MiB	11.92MiB	11.94MiB	0.462705
('syslog_regex_logs2metric_ddmetrics', 'comparison', '0a121e59-e6f8-431e-9e1e-40e4af0a2a9e')	200	11.72MiB	139.96KiB	11.49MiB	11.69MiB	11.93MiB	12.01MiB	12.07MiB	12.18MiB	0.951167
('syslog_regex_logs2metric_ddmetrics', 'baseline', 'cd617deb-6a5b-45c9-b367-d6d8a8f0e49a')	77	11.29MiB	1.98MiB	49.54KiB	11.66MiB	11.74MiB	11.81MiB	11.99MiB	12.02MiB	-5.2927
('splunk_transforms_splunk3', 'baseline', '769b8249-4ee6-4ae6-aafd-8a05c03751ef')	203	9.53MiB	1.76MiB	5.94MiB	9.65MiB	11.69MiB	12.09MiB	13.59MiB	14.9MiB	0.104279
('splunk_transforms_splunk3', 'baseline', 'fff0eb52-8544-46e3-a1de-211d175e3abf')	203	9.44MiB	1.81MiB	5.3MiB	9.36MiB	11.63MiB	12.12MiB	13.29MiB	14.29MiB	0.0468884
('splunk_transforms_splunk3', 'comparison', 'c2453ced-e038-4ebc-bb10-72239d15a023')	202	9.44MiB	1.71MiB	5.8MiB	9.41MiB	11.6MiB	12.08MiB	13.24MiB	13.93MiB	0.0305029
('splunk_transforms_splunk3', 'baseline', '6a945233-ba13-4166-a947-5eb7d79fc0cd')	203	9.42MiB	1.74MiB	5.08MiB	9.46MiB	11.76MiB	12.21MiB	12.78MiB	13.33MiB	-0.00968438
('splunk_transforms_splunk3', 'comparison', '982116f5-7f0f-4ef0-ba9b-361c85e341a4')	202	9.39MiB	1.85MiB	6.05MiB	9.51MiB	11.77MiB	12.39MiB	13.16MiB	13.3MiB	0.0723704
('splunk_transforms_splunk3', 'comparison', 'e6fd441a-45b7-43c6-a1c4-6e3833c50bfd')	202	9.35MiB	1.66MiB	4.77MiB	9.42MiB	11.35MiB	11.9MiB	12.57MiB	13.2MiB	-0.194327
('http_datadog_filter_blackhole', 'comparison', '7d8c32e6-792e-4e6c-9086-348b98503211')	201	6.22MiB	689.5KiB	4.86MiB	6.11MiB	7.1MiB	7.31MiB	8.0MiB	8.57MiB	0.371111
('http_datadog_filter_blackhole', 'baseline', '2f56c2fe-c444-449d-81f8-3dfc278b61b1')	202	6.22MiB	648.02KiB	4.85MiB	6.19MiB	7.08MiB	7.24MiB	7.58MiB	7.75MiB	0.120395
('http_datadog_filter_blackhole', 'baseline', '58fe7b67-fba5-4db1-ab25-439d589f8ea9')	202	6.19MiB	582.32KiB	4.89MiB	6.12MiB	6.97MiB	7.26MiB	7.7MiB	7.99MiB	0.529634
('http_datadog_filter_blackhole', 'comparison', 'f784f193-81a3-421d-ba97-3dee4a1ff07c')	201	6.11MiB	684.22KiB	4.61MiB	6.03MiB	7.05MiB	7.31MiB	7.61MiB	8.18MiB	0.353432
('http_datadog_filter_blackhole', 'baseline', '595a2fea-68ba-4216-9d44-575150c717a1')	202	6.11MiB	631.89KiB	4.64MiB	6.05MiB	6.94MiB	7.24MiB	7.63MiB	8.0MiB	0.415707
('http_datadog_filter_blackhole', 'comparison', 'f0492d28-4478-4040-b0de-e653ae486a63')	201	6.1MiB	702.42KiB	4.56MiB	6.04MiB	7.01MiB	7.19MiB	7.77MiB	8.78MiB	0.519836
('http_pipelines_no_grok_blackhole', 'baseline', 'c8d1df56-135f-478c-951b-f96a6ff4b7c8')	200	5.92MiB	634.99KiB	4.62MiB	5.9MiB	6.83MiB	6.95MiB	7.31MiB	7.94MiB	0.369687
('http_pipelines_no_grok_blackhole', 'baseline', '1c3609f7-23e4-4893-b39a-86c35856f8a6')	200	5.87MiB	632.87KiB	4.5MiB	5.77MiB	6.74MiB	6.95MiB	7.21MiB	7.58MiB	0.353901
('http_pipelines_no_grok_blackhole', 'baseline', '7f4e1840-a661-4407-a991-163038a85f55')	205	5.84MiB	619.43KiB	4.55MiB	5.81MiB	6.6MiB	6.94MiB	7.49MiB	7.92MiB	0.55852
('http_pipelines_no_grok_blackhole', 'comparison', '03f3325e-3cf5-4bca-a53e-b71b43b28ca8')	200	5.83MiB	637.86KiB	4.58MiB	5.79MiB	6.55MiB	6.78MiB	7.8MiB	8.82MiB	0.853599
('http_pipelines_no_grok_blackhole', 'comparison', 'b79a9818-a291-44f5-9d73-20fce188aa05')	200	5.79MiB	595.16KiB	4.24MiB	5.73MiB	6.59MiB	6.77MiB	7.33MiB	7.55MiB	0.418443
('http_pipelines_no_grok_blackhole', 'comparison', '6251b915-3f66-403b-8ff0-8b7e3919b576')	200	5.71MiB	604.14KiB	4.16MiB	5.7MiB	6.52MiB	6.68MiB	7.07MiB	7.38MiB	0.180478
('http_pipelines_blackhole_acks', 'comparison', '47191e0f-9a0a-41e1-808f-b0e440735680')	195	650.04KiB	443.85KiB	15.99KiB	599.24KiB	1.3MiB	1.49MiB	1.78MiB	1.81MiB	0.693637
('http_pipelines_blackhole', 'comparison', '98527cc9-5f4e-4748-a9ba-6f04f11843ff')	196	648.04KiB	499.19KiB	15.99KiB	543.78KiB	1.33MiB	1.6MiB	2.2MiB	2.9MiB	1.43232
('http_pipelines_blackhole', 'baseline', '0bd51dc1-319d-4979-a3bf-78e86e88de2a')	194	639.27KiB	400.76KiB	15.99KiB	582.41KiB	1.13MiB	1.38MiB	1.56MiB	2.03MiB	0.679232
('http_pipelines_blackhole_acks', 'comparison', '8e57d7ae-85ab-4a76-9d03-97635ba6e0c0')	195	638.73KiB	492.79KiB	15.99KiB	555.6KiB	1.34MiB	1.6MiB	1.94MiB	2.14MiB	0.937982
('http_pipelines_blackhole_acks', 'comparison', '3f90d4bd-669e-4791-944f-05f807f20ebe')	196	637.75KiB	472.93KiB	15.99KiB	545.69KiB	1.27MiB	1.47MiB	1.91MiB	2.56MiB	0.921222
('http_pipelines_blackhole', 'comparison', '4d895fe1-5a56-45cb-812d-2d07b2467c7a')	196	635.96KiB	411.47KiB	15.99KiB	589.82KiB	1.17MiB	1.32MiB	1.6MiB	1.75MiB	0.523307
('http_pipelines_blackhole', 'baseline', '79bd03a0-3197-4463-a6a1-052f6bc3ac84')	195	633.5KiB	455.25KiB	15.99KiB	550.68KiB	1.2MiB	1.37MiB	1.92MiB	2.53MiB	0.968471
('http_pipelines_blackhole', 'comparison', 'bbfe682e-f257-47b0-a4b4-c3dbc18953a1')	197	631.94KiB	515.55KiB	15.99KiB	506.0KiB	1.4MiB	1.62MiB	1.95MiB	2.18MiB	1.00522
('http_pipelines_blackhole', 'baseline', '0ce06a4e-8979-4ffb-b590-39d627c51b3e')	195	629.57KiB	471.62KiB	15.99KiB	550.68KiB	1.22MiB	1.57MiB	1.99MiB	2.08MiB	0.879713
('http_pipelines_blackhole_acks', 'baseline', 'dce99291-d2ad-4815-ae16-f05f258cf1ab')	197	628.06KiB	468.07KiB	15.99KiB	552.36KiB	1.21MiB	1.49MiB	1.91MiB	2.15MiB	0.896873
('http_pipelines_blackhole_acks', 'baseline', '616dbac2-0883-416e-9c07-4b23118577de')	198	627.6KiB	434.4KiB	15.99KiB	524.16KiB	1.2MiB	1.4MiB	1.65MiB	2.08MiB	0.779137
('http_pipelines_blackhole_acks', 'baseline', '19b2ddf3-4841-4e73-90b8-8ce588d1b4e4')	197	622.22KiB	446.06KiB	15.99KiB	520.9KiB	1.25MiB	1.41MiB	1.69MiB	1.93MiB	0.68809

Mar 18 '22 20:03 github-actions[bot]

Thanks for reviewing @bruceg . I realize I completely forgot about Windows here so I'll need to rework this a bit to abstract the signaling bits. I'll move this back into draft until I do that.

Mar 18 '22 22:03 jszwedko

How does it look like with merging this PR? I am using it for some time in custom build and it works fine.

Moreover.. who cares about Windows? 🤯 If it's problematic to support Windows API right away, why not to merge this to fix 99,9% use-cases and add Windows support later?

Jul 19 '22 17:07 fpytloun

Moreover.. who cares about Windows? 🤯 If it's problematic to support Windows API right away, why not to merge this to fix 99,9% use-cases and add Windows support later?

That's a fair point 😄 We could make this a *nix only feature for now. I'll try to take another pass at this this or next week.

Jul 19 '22 20:07 jszwedko

Moving this out of draft as I implemented non-graceful shutdown for Windows processes (to be improved later).

Aug 04 '22 19:08 jszwedko

I have a couple of suggestions below. I am also wondering if this will fail to terminate subprocesses that don't respond to the signal on Unix. That is, if the subprocess is killed but doesn't actually exit before Vector finishes shutting down, that subprocess will still be hanging around if I'm reading this right.

I'm not exactly sure how it happens, but it does appear that the child is abruptly terminated whenever the Vector process exits. I tested on OSX and Linux.

I tested with this config:

[sources.source0]
command = ["bash", "-c", "trap 'echo signal received ; sleep 10000; echo slept ; exit' SIGINT; while true ; do sleep 1 ; done"]
mode = "streaming"
type = "exec"

[sinks.sink0]
inputs = ["source0"]
target = "stdout"
type = "console"

[sinks.sink0.encoding]
codec = "json"

And observed, after issuing the SIGTERM, that Vector would wait the 60 seconds before exiting abruptly, taking the subprocess with it.

Aug 09 '22 17:08 jszwedko

Soak Test Results

Baseline: 1ec6c9ddd9e5a6025637de68588e614e8b569da6 Comparison: 567c5bb72f78662f72415dab5a4b0dec164f318a Total Vector CPUs: 4

Explanation

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.

experiment	Δ mean	Δ mean %	confidence	baseline mean	baseline stdev	baseline stderr	baseline CoV	comparison mean	comparison stdev	comparison stderr	comparison CoV	erratic	declared erratic
syslog_humio_logs	745.28KiB	4.55	100.00%	15.98MiB	753.6KiB	15.39KiB	0.0460475	16.71MiB	660.84KiB	13.53KiB	0.0386201	False	False
syslog_log2metric_splunk_hec_metrics	640.23KiB	3.71	100.00%	16.84MiB	1.02MiB	21.35KiB	0.0607606	17.47MiB	1004.88KiB	20.47KiB	0.0561612	False	False
syslog_splunk_hec_logs	435.83KiB	2.62	100.00%	16.27MiB	658.33KiB	13.42KiB	0.0395047	16.7MiB	567.89KiB	11.58KiB	0.0332086	False	False
splunk_hec_route_s3	425.22KiB	2.26	100.00%	18.37MiB	2.38MiB	49.51KiB	0.129336	18.79MiB	2.27MiB	47.49KiB	0.12083	False	False
syslog_regex_logs2metric_ddmetrics	239.31KiB	1.87	100.00%	12.5MiB	596.61KiB	12.15KiB	0.0466037	12.73MiB	636.34KiB	12.96KiB	0.0487948	False	False
http_text_to_http_json	671.94KiB	1.74	100.00%	37.78MiB	2.22MiB	46.47KiB	0.0588331	38.43MiB	1.34MiB	27.92KiB	0.0347474	False	False
datadog_agent_remap_blackhole_acks	862.2KiB	1.37	100.00%	61.3MiB	5.27MiB	109.77KiB	0.0860132	62.14MiB	4.15MiB	86.83KiB	0.0667804	False	False
http_to_http_acks	242.86KiB	1.36	67.17%	17.41MiB	8.11MiB	169.62KiB	0.46587	17.65MiB	8.7MiB	181.5KiB	0.492603	True	True
syslog_loki	196.58KiB	1.33	100.00%	14.44MiB	666.18KiB	13.63KiB	0.0450468	14.63MiB	975.77KiB	19.84KiB	0.0651161	False	False
socket_to_socket_blackhole	203.08KiB	0.87	100.00%	22.85MiB	726.49KiB	14.83KiB	0.0310368	23.05MiB	674.76KiB	13.78KiB	0.0285787	False	False
datadog_agent_remap_datadog_logs	555.98KiB	0.86	100.00%	63.17MiB	1.13MiB	23.67KiB	0.0178844	63.71MiB	3.8MiB	79.22KiB	0.0596489	False	False
datadog_agent_remap_datadog_logs_acks	440.71KiB	0.69	99.97%	62.48MiB	3.57MiB	74.51KiB	0.0570685	62.91MiB	4.58MiB	95.34KiB	0.0727814	False	False
datadog_agent_remap_blackhole	221.83KiB	0.34	97.24%	63.24MiB	3.91MiB	81.5KiB	0.0617771	63.46MiB	2.83MiB	59.09KiB	0.0446096	False	False
splunk_hec_indexer_ack_blackhole	21.54KiB	0.09	62.65%	23.74MiB	886.46KiB	18.02KiB	0.0364522	23.76MiB	793.93KiB	16.16KiB	0.0326185	False	False
splunk_hec_to_splunk_hec_logs_noack	17.25KiB	0.07	86.22%	23.82MiB	465.39KiB	9.5KiB	0.0190756	23.84MiB	327.75KiB	6.69KiB	0.0134243	False	False
splunk_hec_to_splunk_hec_logs_acks	3.19KiB	0.01	10.27%	23.75MiB	866.12KiB	17.61KiB	0.0356095	23.75MiB	854.12KiB	17.37KiB	0.0351113	False	False
enterprise_http_to_http	1.89KiB	0.01	20.32%	23.84MiB	254.73KiB	5.2KiB	0.0104307	23.85MiB	252.81KiB	5.17KiB	0.0103509	False	False
file_to_blackhole	-48.95KiB	-0.05	35.79%	95.34MiB	3.36MiB	69.68KiB	0.0352477	95.29MiB	3.8MiB	78.98KiB	0.0398431	False	False
http_to_http_json	-22.03KiB	-0.09	93.19%	23.84MiB	349.06KiB	7.13KiB	0.014293	23.82MiB	476.51KiB	9.74KiB	0.0195294	False	False
http_pipelines_blackhole_acks	-1.93KiB	-0.16	47.57%	1.16MiB	105.72KiB	2.15KiB	0.088617	1.16MiB	104.6KiB	2.13KiB	0.0878234	False	False
fluent_elasticsearch	-204.42KiB	-0.25	100.00%	79.47MiB	50.73KiB	1.03KiB	0.000623292	79.27MiB	1.77MiB	36.36KiB	0.0222805	False	False
http_to_http_noack	-68.21KiB	-0.28	99.95%	23.85MiB	258.4KiB	5.29KiB	0.0105801	23.78MiB	929.65KiB	18.94KiB	0.0381712	False	False
http_pipelines_no_grok_blackhole	-75.87KiB	-0.66	99.90%	11.22MiB	44.75KiB	935.57B	0.00389411	11.15MiB	1.11MiB	23.07KiB	0.0994073	False	False
syslog_log2metric_humio_metrics	-139.23KiB	-1.11	100.00%	12.23MiB	617.44KiB	12.6KiB	0.0492788	12.1MiB	628.93KiB	12.81KiB	0.05076	False	False
http_pipelines_blackhole	-21.02KiB	-1.3	100.00%	1.57MiB	79.93KiB	1.63KiB	0.0495659	1.55MiB	147.19KiB	3.0KiB	0.0924757	False	False

Aug 09 '22 18:08 github-actions[bot]

Soak Test Results

Baseline: 146c129d63587544b85dae542ba84587dd9b8643 Comparison: 634d9107b69d141273f169de0366c4605468bb3b Total Vector CPUs: 4

Explanation

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.

experiment	Δ mean	Δ mean %	confidence	baseline mean	baseline stdev	baseline stderr	baseline CoV	comparison mean	comparison stdev	comparison stderr	comparison CoV	erratic	declared erratic
http_text_to_http_json	562.83KiB	1.41	100.00%	38.86MiB	808.37KiB	16.5KiB	0.0203078	39.41MiB	782.16KiB	15.97KiB	0.0193753	False	False
http_pipelines_blackhole_acks	9.34KiB	0.81	99.85%	1.13MiB	119.51KiB	2.43KiB	0.103582	1.14MiB	81.52KiB	1.66KiB	0.0700851	False	False
splunk_hec_route_s3	97.55KiB	0.53	83.07%	18.11MiB	2.44MiB	50.75KiB	0.134564	18.21MiB	2.37MiB	49.59KiB	0.130204	False	False
http_to_http_acks	52.18KiB	0.3	17.27%	17.26MiB	8.05MiB	168.28KiB	0.466254	17.31MiB	8.13MiB	169.87KiB	0.469666	True	True
datadog_agent_remap_blackhole	168.03KiB	0.27	83.51%	60.9MiB	4.53MiB	94.5KiB	0.0744437	61.06MiB	3.62MiB	75.51KiB	0.0592394	False	False
syslog_splunk_hec_logs	11.04KiB	0.07	41.14%	16.47MiB	713.62KiB	14.53KiB	0.0423036	16.48MiB	703.3KiB	14.32KiB	0.0416646	False	False
splunk_hec_to_splunk_hec_logs_noack	15.62KiB	0.06	81.61%	23.82MiB	470.55KiB	9.6KiB	0.0192856	23.84MiB	331.95KiB	6.78KiB	0.0135965	False	False
syslog_humio_logs	6.08KiB	0.04	92.46%	16.63MiB	126.23KiB	2.58KiB	0.00741035	16.64MiB	109.53KiB	2.24KiB	0.00642785	False	False
enterprise_http_to_http	-174.9B	-0	1.88%	23.85MiB	250.08KiB	5.1KiB	0.0102393	23.85MiB	252.02KiB	5.15KiB	0.0103188	False	False
splunk_hec_indexer_ack_blackhole	-3.43KiB	-0.01	10.56%	23.75MiB	884.57KiB	17.99KiB	0.0363694	23.74MiB	912.57KiB	18.56KiB	0.0375259	False	False
splunk_hec_to_splunk_hec_logs_acks	-8.78KiB	-0.04	28.70%	23.77MiB	807.77KiB	16.44KiB	0.0331843	23.76MiB	850.36KiB	17.3KiB	0.0349463	False	False
http_to_http_json	-22.07KiB	-0.09	93.96%	23.85MiB	344.47KiB	7.03KiB	0.0141043	23.82MiB	460.09KiB	9.41KiB	0.0188553	False	False
file_to_blackhole	-104.42KiB	-0.11	68.65%	95.34MiB	3.23MiB	67.02KiB	0.0339032	95.24MiB	3.8MiB	78.99KiB	0.0399247	False	False
http_to_http_noack	-48.38KiB	-0.2	97.40%	23.83MiB	523.45KiB	10.7KiB	0.0214507	23.78MiB	927.92KiB	18.91KiB	0.0381013	False	False
fluent_elasticsearch	-200.77KiB	-0.25	100.00%	79.47MiB	52.93KiB	1.07KiB	0.000650222	79.28MiB	1.77MiB	36.36KiB	0.0222733	False	False
http_pipelines_blackhole	-4.58KiB	-0.28	94.88%	1.59MiB	38.32KiB	802.34B	0.023478	1.59MiB	108.47KiB	2.21KiB	0.0666436	False	False
datadog_agent_remap_datadog_logs_acks	-264.23KiB	-0.41	98.28%	62.58MiB	3.13MiB	65.44KiB	0.0500232	62.32MiB	4.3MiB	89.52KiB	0.0689846	False	False
syslog_log2metric_splunk_hec_metrics	-102.35KiB	-0.55	100.00%	18.01MiB	521.21KiB	10.63KiB	0.0282551	17.91MiB	798.06KiB	16.24KiB	0.0435044	False	False
datadog_agent_remap_datadog_logs	-431.88KiB	-0.66	100.00%	63.56MiB	267.32KiB	5.47KiB	0.00410668	63.13MiB	4.01MiB	83.61KiB	0.0635591	False	False
datadog_agent_remap_blackhole_acks	-541.63KiB	-0.82	100.00%	64.5MiB	4.29MiB	89.35KiB	0.066493	63.97MiB	3.93MiB	82.11KiB	0.0613528	False	False
socket_to_socket_blackhole	-199.65KiB	-0.86	100.00%	22.58MiB	788.21KiB	16.09KiB	0.0340799	22.39MiB	725.02KiB	14.8KiB	0.0316208	False	False
syslog_regex_logs2metric_ddmetrics	-117.14KiB	-0.92	100.00%	12.44MiB	570.83KiB	11.63KiB	0.0448195	12.32MiB	461.9KiB	9.42KiB	0.0366029	False	False
syslog_log2metric_humio_metrics	-128.45KiB	-1.04	100.00%	12.11MiB	209.03KiB	4.27KiB	0.0168573	11.98MiB	498.19KiB	10.14KiB	0.0405967	False	False
http_pipelines_no_grok_blackhole	-201.03KiB	-1.79	100.00%	10.97MiB	252.54KiB	5.16KiB	0.0224689	10.78MiB	1.04MiB	21.61KiB	0.0962467	False	False
syslog_loki	-455.93KiB	-3.04	100.00%	14.67MiB	419.59KiB	8.59KiB	0.027931	14.22MiB	769.19KiB	15.64KiB	0.0528055	False	False

Aug 12 '22 16:08 github-actions[bot]

fix(exec source): Fix graceful shutdown behavior

✅ Deploy Preview for vector-project ready!

Soak Test Results

Soak Test Results

Soak Test Results

Deploy Preview for vector-project ready!