jswxstw
jswxstw
I‘ve tried implementing this enhancement myself and found that there are some issues that need to be addressed. ### Containers and their lifecycle in the agent pod are different from...
I've tested it locally. There are two executor plugins in namespace `argo` and `khaos-workflow`. ```shell # kubectl get cm -A -l workflows.argoproj.io/configmap-type=ExecutorPlugin NAMESPACE NAME DATA AGE khaos-workflow khaos-steps-executor-plugin 2 21m...
The agent pod will only be created if `taskSet` is not empty. Each workflow can have at most one agent pod. https://github.com/argoproj/argo-workflows/blob/5c8062e55d975aab117e37c7592c0a648a9e9860/workflow/controller/agent.go#L32-L46 Only http and plugin template will be put...
> @jswxstw do u want to create PR? I see you have created a PR and it looks good to me basically. The only problem is that you can use...
I believe that supporting version control for workflows and templates is crucial, rather than directly updating existing objects, which can be a risky operation.
> The update action should still have many uses. Completely agree. In fact, we have implemented our own logic for updating workflows based on the Kubernetes client to enable intervention...
The agent pod deletion logic is currently performed in `markWorkflowPhase` and the PodGC strategy is invalid to the agent pod, so I think it is more appropriate to put it...
> The agent pod deletion logic is currently performed in `markWorkflowPhase` and the PodGC strategy is invalid to the agent pod, so I think it is more appropriate to put...
It seems unreliable to determine whether the task result has been successfully reported through the `AnnotationKeyReportOutputsCompleted`.
This issue is very similar to https://github.com/argoproj/argo-workflows/discussions/12729, just the opposite. The difference lies in whether the `ClusterWorkflowTemplate` is used as a WFT or a WF. If you use the `ClusterWorkflowTemplate`...