argo-workflows
argo-workflows copied to clipboard
Add update flag in the create command
Summary
Add update flag in the create command.
Use Cases
User want to use 1 command to create or update an resource(cron wf、workflow template、clusterworkflowtemplate).
edited by agilgur5: Source https://github.com/argoproj/argo-workflows/pull/12803#pullrequestreview-1945224384
Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritize the proposals with the most 👍.
Add update flag in the create command.
I don't think this should be done. create
and update
are two separate verbs
in k8s and CRUD conventions more generically. We should not be re-inventing the wheel nor breaking existing conventions, which makes maintenance more difficult and UX more confusing.
Not to mention create --update
is actually longer to type than update
, so I do not see any benefit in this, only cons.
User want to use 1 command to create or update an resource
It sounds like you might be looking for apply
, for example kubectl apply
, which is a third, separate command
I believe that supporting version control for workflows and templates is crucial, rather than directly updating existing objects, which can be a risky operation.
I believe that supporting version control for workflows and templates is crucial, rather than directly updating existing objects, which can be a risky operation.
The update action should still have many uses. If think the risk is high, can not use this API. Version control may be a more advanced use and requires more design.
The update action should still have many uses.
Completely agree. In fact, we have implemented our own logic for updating workflows based on the Kubernetes client to enable intervention operations such as step skipping and parameter updates.
This issue has been automatically marked as stale because it has not had recent activity and needs more information. It will be closed if no further activity occurs.
As I wrote above and elsewhere, I can agree to an apply
command, but create --update
seems like a confusing anti-pattern to me
This issue has been automatically marked as stale because it has not had recent activity and needs more information. It will be closed if no further activity occurs.
This issue has been closed due to inactivity and lack of information. If you still encounter this issue, please add the requested information and re-open.