James Sumners

Results 658 comments of James Sumners

I have a suspicion this is awesome. I will review when I have some time to dig through it.

Should I be doing something around this?

Seems like some sort of race condition? Later that same day I didn't have a problem with it working. 🤷‍♂

That is most easily accomplished through file naming. Otherwise, we'd have to maintain a JSON file or something to provide this information.

I do not see a "fair" way to implement pinning outside of sponsorship. With this PR we are pinning a completely new addition to the list that, so far, isn't...

I agree in principle, @lmammino. But let's look at our own website. The main `index.html` says: ![image](https://user-images.githubusercontent.com/321201/91716457-b20e7800-eb5d-11ea-9e71-a03a87896b83.png) And that link directs to: ![image](https://user-images.githubusercontent.com/321201/91716487-c9e5fc00-eb5d-11ea-997e-84474270ff40.png) So another issue is presented: we are...

Okay, given that explanation, if the home page is completely taken up by pinned orgs, then we cannot say "do you want to be featured here" on the home page....

I don't think the copy can be clarified if the list on the home page is a mix of pinned and unpinned. The list should consist solely of pinned logos,...

> * company/org enables some employee to contribute back to the fastify community (code, docs, tests, tutorials, core-plugins) > * company/org continues to produce meaningful contributions at least once every...