node-clinic bubbleprof links the trace instead of moving it

bubbleprof links the trace instead of moving it

Open jsumners opened this issue 4 years ago • 4 comments

This is from running in a Docker container with -v /tmp:/tmp and running clinic --collect-only --dest /tmp:

app yml — backyard-api 2020-03-06 14-49-58

Mar 06 '20 19:03 jsumners

@jasnell - I saw some issues reported on Docker, does this relate to anything you reported? Maybe #74

Mar 11 '20 11:03 DylanC

we could use something like the move-file module instead of fs.rename, it should avoid the cross-device issue.

Mar 11 '20 14:03 goto-bus-stop

Seems like some sort of race condition? Later that same day I didn't have a problem with it working. 🤷‍♂

Mar 11 '20 14:03 jsumners

Using fs.rename() with docker containers is notoriously tricky and flaky. Using a file copy may be more reliable.

Mar 11 '20 15:03 jasnell