Joshua Schmid

Results 75 comments of Joshua Schmid

![](https://github.trello.services/images/mini-trello-icon.png) [Add unit/func tests for the engulfment process](https://trello.com/c/7uu9MgNa/32-add-unit-func-tests-for-the-engulfment-process)

> This means we need an integration test that deploys SES4 with ceph-deploy. right

> The deepsea stage run ceph.maintenance.upgrade should check if a reboot of a node is really required and only reboot the node in case it is required. In case it...

can you post the output of: `salt 'the_node_in_question' grains.get kernelrelease` and `salt 'the_node_in_question' cmd.run 'rpm -q --last kernel-default | head -1'`

We have a alternating implementation in master, currently evaluating if its worth to backport this.

> We have a alternating implementation in master, currently evaluating if its worth to backport this. This should be backported. Included in this commit: https://github.com/SUSE/DeepSea/commit/bb032916e22a73d7afe216f6fd114eb6b80326cc#diff-e87ed67149dac86de0d18a896ad7b87d Increased priority.

the pending branch wip-functional-tests includes a functional test for ceph.conf generation which might still be useful.