Joshua Schmid

Results 75 comments of Joshua Schmid

Here you can find my approach to the problem: https://github.com/SUSE/DeepSea/commit/aec0ce00a6c2e16bd3a470c8b69c0bce3a5f5f91 taken from branch https://github.com/SUSE/DeepSea/compare/next...return_struct_next?expand=1 I went with the existing podman modules and extended it with a class that acts as...

I extended the return structure a bit and added the bit for `CalledProcessError`: ~The new commit can be found here https://github.com/SUSE/DeepSea/commit/c5eb793e794ec06286b2b1586d0bb6e006d5c36e~ updated: https://github.com/SUSE/DeepSea/commit/1f4e1c0ab4b86851b4b0b40e724c975fa157d335 ``` local: ---------- command: /usr/bin/podman run --rm...

update the commit with some more improvements: https://github.com/SUSE/DeepSea/commit/1f4e1c0ab4b86851b4b0b40e724c975fa157d335 I also factored multiple functions into non-salt managed files for re-usability.

> @jschmid1 that looks like a bug inside Salt, because the exception is being raised inside the salt python library. you are right.. so unfortunately we can't do anything about...

@rjfd doesn't the reproducer steps in the description work for you?

our tests(and the libs we are relying on) are just not ported to py3. we have about 50~ tests failing when switching to python3

trying to tackle with https://github.com/SUSE/DeepSea/pull/1195

Agreed. Here's the line# https://github.com/SUSE/DeepSea/blob/SES5/srv/salt/_modules/osd.py#L644 edit(that _was_ the line)