jschleicher
jschleicher
We drop the `wait` for now and issue a warning, if the state is too old. I'm preparing a PR.
@agutenkunst There are more places which `waitForCurrentState`, e.g. [trajectory_execution_manager:1539](https://github.com/ros-planning/moveit/blob/062381c75847ab8dc68e022e8987ebf514c8484b/moveit_ros/planning/trajectory_execution_manager/src/trajectory_execution_manager.cpp#L1537-L1541), [trajectory_execution_manager.cpp:940](https://github.com/ros-planning/moveit/blob/062381c75847ab8dc68e022e8987ebf514c8484b/moveit_ros/planning/trajectory_execution_manager/src/trajectory_execution_manager.cpp#L940) and [plan_execution.cpp:412](https://github.com/ros-planning/moveit/blob/062381c75847ab8dc68e022e8987ebf514c8484b/moveit_ros/planning/plan_execution/src/plan_execution.cpp#L412-L416) . I'd want to time and measure them altogether...
Regarding the test I guess it's the same as in https://github.com/ros/actionlib/pull/156#issuecomment-595713514.
This issue probably makes the tests currently flaky, see [unstable build for PR #158](http://build.ros.org/job/Npr_db__actionlib__debian_buster_amd64/10/console) ``` 14:12:55 [Testcase: testtest_cpp_simple_client] ... ERROR! 14:12:55 ERROR: max time [60.0s] allotted for test [test_cpp_simple_client] of...
@mjcarroll This check is copied from cpp to the python client (see #126). Please review.
Probably one would want a similar check as in cpp 3db5a80d2363ddef4ffb0abc4d5bcb44c8670708 for the python client. The python client lacks such a "ignore cancel request" section https://github.com/ros/actionlib/blob/7c1833418c52ef857fbd2aae9954ccc3796b42a6/src/actionlib/action_client.py#L139
During startup, the console shows an error ``` [ INFO] [1601639295.430965133]: Recovering... [ INFO] [1601639295.431048654]: Recovering successful [ERROR] [1601639295.433443366]: Service: /prbt/manipulator_joint_trajectory_controller/unhold failed with error message: Could not switch to unhold...
As said in #1397: I'm not a panda expert; updating the tutorials should also re-generate the [`panda_moveit_config`](https://github.com/ros-planning/panda_moveit_config/blob/melodic-devel/launch/move_group.launch). I'm not feeling confident about making this change.