actionlib Trigger goal cancelling depending on client state. Fixes #126

Trigger goal cancelling depending on client state. Fixes #126

Open martiniil opened this issue 6 years ago • 6 comments

This prevents an undesirable transition from DONE to WAITING_FOR_CANCEL_ACK. See https://github.com/ros/actionlib/issues/126

Mar 22 '19 06:03 martiniil

@mjcarroll This check is copied from cpp to the python client (see #126). Please review.

May 20 '19 09:05 jschleicher

I am also getting the Received comm state PREEMPTING when in simple state DONE with SimpleActionClient errors. Is anything holding this PR back?

Jul 27 '20 13:07 Timple

I am also getting the Received comm state PREEMPTING when in simple state DONE with SimpleActionClient errors. Is anything holding this PR back?

Aug 07 '20 19:08 zhuang42

Thanks for the approval! Who has the authority to hit the merge button?

Aug 24 '20 08:08 Timple

A subtle ping to @mjcarroll because he did the last release and probably has some rights here :slightly_smiling_face:

Oct 12 '20 12:10 Timple

The ping is broken :cry:

Jul 23 '24 10:07 Timple