jschanker

Results 22 comments of jschanker

Hi Abby, thanks for reviewing this. I completely agree. What started out as a simple idea for a plugin to handle dependent dropdowns became more complex when I uncovered these...

Hi Abby, The combobox field plugin sounds like a great one to start with! One student responded that he'd be interested in working on this one, and I'm sure the...

@alschmiedt No worries at all, and thank you very much for spending the time looking into this! The most (recently) used blocks dynamic category sounds like a straightforward plugin to...

Closing for https://github.com/navgurukul/bhanwari-devi/pull/1116 instead

@kartiks26 Will try to look at this at the end of the week when I have some more time.

@kartiks26 I noticed that the problem was that the other menus were being covered so `onMouseEnter` didn't work. Removing `fixed` positioning works. Again, don't really have time to work on...

@Poonam-Singh-Bagh @kartiks26 @saquibaijaz To give an update on this, the issue for the Learn/About/Get Involved dropdowns is fixed by https://github.com/navgurukul/bhanwari-devi/pull/740. You can see that here: https://bhanwari-devi-kt6o3pt7s-navgurukul-meraki.vercel.app/ . The strategy I...

@Poonam-Singh-Bagh Unfortunately, this is because of some semi-duplicated code. I made the correction for the public learn dropdown in https://github.com/navgurukul/bhanwari-devi/blob/fix/hover-menu-close-on-leave/src/components/Header/index.js#L91-L147, but not for the learn menu for the student header...

@amansharmma I've returned to this, but I have to think how to best factor out the commonality.

@Poonam-Singh-Bagh Yes, I'm starting work on this issue again.