jschanker
jschanker
@Poonam-Singh-Bagh @saquibaijaz Now fixed to use common `DropDownMenu` and `TextButtonDropDownMenu` components for User/Switch Roles menus (but not deployed to `dev` server, available at https://bhanwari-devi-mc9iqsoyx-navgurukul-meraki.vercel.app/). Works for the sidebar navigation with...
@saquibaijaz Related to this is https://github.com/navgurukul/bhanwari-devi/issues/803 where the user menu also has a scrollbar. When it's in the sidebar, do we want it to be in the page flow and...
> @jschanker we need to fix this scrollbar at the side of the dropdown Cc: @Poonam-Singh-Bagh  Scrollbar issue fixed. The vertical padding on the inline `a` element was causing...
@saquibaijaz There might be some small changes that are needed to PR #740 such as decreasing the delay for a menu to close so they don't appear on top of...
@saquibaijaz Seems to be another issue with the `Menu` component (https://github.com/mui/material-ui/issues/5185). I tried resolving this with `disableScrollLock` but it didn't redeploy on Vercel for some reason so I'm not sure...
@saquibaijaz It eventually deployed. Maybe there were other deployments in progress holding this one up. Seems to work now: https://bhanwari-devi-5dczeisd7-navgurukul-meraki.vercel.app/
@itsomkathe Looks good to me for basic search. In the future, we may want to add options such as limiting the number of results, only including results that start with...
@itsomkathe All you would have to do is create a `SearchService.test.js` file and provide example inputs with expected outputs for `search` using https://jestjs.io/docs/expect. I wrote about this and unit tests...
Upgrading to React 18+ is particularly important for improving performance (See for example, https://dev.to/this-is-learning/automatic-batching-in-react-18-273h). There are a number of places where we perform multiple state updates upon receiving API responses...
> will this be real-time as a volunteer creates a batch will it reflect to student as soon as it is created?? @kartiks26 Not currently, but we can schedule it...