José Armando García Sancio

Results 35 comments of José Armando García Sancio

@Smeb This is marked as a blocker for 3.3.0. It looks like there are merge conflicts with trunk. Let's find a committer to review this PR.

@lqjack I am closing the PR. It looks like this issue was fixed by https://github.com/apache/kafka/pull/12206 and https://github.com/apache/kafka/pull/12508

Thanks for the changes @ashmeet13 they look good in general. > 1. How do we handle multiple reasons for starting a snapshot in an enum? Instead of using `Optional[SnapshotReason]` we...

> Thanks @jsancio, this is helpful. I'll go ahead and make these changes! @ashmeet13 , I thought about this some more and I don't think we should include the reason...

> Hi @jsancio, just one another doubt - Does this mean we don't want to log the reason within `KafkaMetadataLog` and keep the logging as it is right now within...

> Hi @jsancio, I have reverted the changes made to `RaftClient` and kept the logging withing `BrokerMetadataSnapshotter` and `QuorumController` > > I have two questions, would really be helpful if...

> Hi @jsancio could you please review this PR? Sorry for the multiple changes this has required. Thanks for the changes and excuse the delays. LGTM in general. Restarted the...

@showuon and @C0urante here is the system test job https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5109/ not sure if you are authorized to see the job. @yashmayya also submitted this fix: https://github.com/apache/kafka/pull/12575. Should we merge that...

> @jsancio We can't access the Jenkins URL you shared (`This page is only accessible by Confluent employees on corporate VPN.`). It would be great to get this into 3.3...

@showuon I tried running the system tests twice in Confluent's infrastructure and we got some infrastructure issues in both cases. Feel free to merge this change and cherry pick it...