José Armando García Sancio

Results 35 comments of José Armando García Sancio

@showuon @C0urante @mimaison these are the test failures: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/system-test-kafka-branch-builder--1662600230--C0urante--kafka-10000-system-tests--2f62b7469/2022-09-07--001./2022-09-07--001./report.html

@C0urante sounds good. Do you want to merge it and cherry-pick it to 3.3? I can also merge it if you update the description with what you want me to...

> here is the code change: https://github.com/dengziming/kafka/tree/KAFKA-13959-2 Hey @dengziming, I took at look at the commits in this tree. Is this the only commit https://github.com/dengziming/kafka/commit/79dc8ec423cd74fba462e934f89bdec3dcd8528d? Can you maybe share a...

> > here is the code change: https://github.com/dengziming/kafka/tree/KAFKA-13959-2 > > Hey @dengziming, I took at look at the commits in this tree. Is this the only commit [dengziming@79dc8ec](https://github.com/dengziming/kafka/commit/79dc8ec423cd74fba462e934f89bdec3dcd8528d)? Can you...

> In this PR I tried your suggestion and it does solve this problem, however, this will make the logic in RaftClient very complex and we need to save more...

> I havn't flesh it, the basic idea is shown in this PR, only read up to Isolation.COMMITTED when reading from observer and invoke fetchPurgatory.maybeComplete(highWatermark.offset, currentTimeMs) on onUpdateLeaderHighWatermark. I see....

> maybe we should allow the lastAppliedOffset to be behind by A records (or time) to unfence the broker. @dengziming Here are my thoughts ### Improve logic for unfencing brokers...

> This is a good idea, however, the offset of each registration record is a soft state(not persist to metadata log) @dengziming The offset is persistent along with the record....

> @jsancio I think the last question is that there may be more than one registration record for each broker after restarting it, so can we rely on the broker...

@dengziming I marked this issue as a blocker to 3.3.0. Let me know if you want to work on this issue. I don't mind.