apache
KAFKA-13978: Don't skip exceptions in Kafka streams custom handlers
Previously IllegalArgumentException and IllegalStateException errors would always trigger an application shutdown. With this change those errors are treated the same as all other exceptions thrown while an application processes a stream, and are processed by the registered uncaught exception handler.
Tested using unit and integration tests. Since this is removing a feature, no new tests were added.
Committer Checklist (excluded from commit message)
- [x] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
CI appears to timeout but I don't see how it could be related to my changes - I can also see that's the case for a lot of other PRs. Is this a known issue? The tests do run locally.
@Smeb This is marked as a blocker for 3.3.0. It looks like there are merge conflicts with trunk. Let's find a committer to review this PR.
Hey @Smeb , I just checked trunk and 3.3, and I don't see the code that you're removing in your PR. It seems like someone else may have fixed this issue in the mean time. Can you confirm whether or not the issue is resolved?
Removing the 3.3 label given the comment from @vvcephei. If it is a blocker for 3.3, please provide the rationale.
