Johnathan Van Why

Results 110 comments of Johnathan Van Why

I realize I should summarize my previous comments, especially because this may be discussed at the next core WG call, which I do not expect to attend. I thought through...

I think it is really hard to support conditional register compilation while also supporting unit-testing functionality (support for fake or mock peripherals).

@jesultra: I added you so you can double-check that I correctly understood the purpose of UartKey.

picolib looks great, with one possible catch. It contains a single AGPL file, and Google is not a fan of the AGPL: https://opensource.google/documentation/reference/using/agpl-policy If Tock wants to go with picolib,...

I'm starting to work on this. I suspect I'll run out of time to send a PR this week but I hope to send one next week.

It turns out that [`redpen`](https://crates.io/crates/redpen-linter) does not catch every possible panic path. For example, it does not error on this program: ```rust pub trait MaybePanic { fn maybe_panic(&self); } pub...

> > Maybe I should enable and address the Clippy lints first, then give Red Pen a try and see how many panics it catches that Clippy doesn't? Then we...

> > IIUC [estebank/redpen@887ea4f](https://github.com/estebank/redpen/commit/887ea4fde5839b7d041d367f30009fe6d4161e39) should fix the specific example provided in [#202 (comment)](https://github.com/google/zerocopy/issues/202#issuecomment-1769693893) > > Does this mean that redpen is now "complete" in the sense that it won't miss...

> Need documentation. In particular, I'd like to see safety requirements of `CoreLocal::new_single_core` -- it's almost impossible to review the rest of this PR for soundness without that documentation.

I recently stumbled across a [Zulip discussion from November](https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/More.20general.20term.20for.20.22threads.22) about `Send` and `Sync` for threads and thread-like things. I don't think the conversation conflicts with anything in this PR, but...