Johnathan Van Why
Johnathan Van Why
> Awesome! Very excited to see some progress here. > > Can you briefly compare to prior approaches, namely your #3405 PR? Ultimately, #3405 was closed because it was unsound...
> One general question, should we use `Fake` or `Mock` consistently through the documents and types here? I have vanishingly little experience with real-world unit testing, but I thought `Mock`...
On the core WG call, someone asked for a document describing how code using `tock-registers` changes. # `register_structs!` version First, here's a "before" example of a theoretical driver that uses...
I had a sentence buried in `README.md` explaining that the [rustdoc on `peripheral!`](https://github.com/jrvanwhy/tock/blob/testable-registers-2/libraries/tock-register-interface/src/peripheral.rs) is more complete than the description in the README, but I think some of the reviewers missed...
> I don't the link to the issue is enough context as I don't think I understand what this is protecting. > > With this PR we would have an...
> > I don't understand the justification for the dual toolchain from this commit [0ae3974](https://github.com/tock/libtock-rs/commit/0ae3974411877c64e383a316c43888cab776696a). > > We want to use a dual-toolchain setup to work around the exact issue...
I think we have three options here: 1. Have Nix provide both needed toolchains, and modify `libtock-rs`' Makefile to call the appropriate toolchain for each command. 2. Use `rustup` even...
Commenting to support this feature request. The project I work on has `-D warnings` in its `.cargo/config`: ```toml [target.'cfg(all())'] rustflags = ["-D", "warnings"] ``` This works great for CI, where...
> You can already do this in your CI. It's just about setting your ENV variable `RUSTFLAGS= -D warnings` and run cargo. That does not work for projects that need...
I would expect the number of examples to grow over time, yes. The documentation is in kindof a bad state right now, because I haven't had time to write it.