Johnathan Van Why

Results 110 comments of Johnathan Van Why

Hmm, I've never needed to debug `libtock-rs`' APIs with a real Tock kernel, the unittest environment has always been enough. Are you trying to debug the drivers before you have...

Okay, now I see why you want this. I think putting these in a separate crate is reasonable. Maybe `libtock_print_macros`? I do not think the new crate should live under...

The `tockloader` PR (tock/tockloader#52) has been merged. I opened the following issue to get support for OpenOCD arguments added to tock: https://github.com/tock/tock/issues/1626

Question: is `expect_used` worth the false positives? It triggered three times: 1. True positive on `AsBytes::write_to_suffix` on a dead branch. I think this `expect` would have been optimized away but...

Question: This branch is already out-of-date and needs changes, do you prefer that I do a merge or that I do a rebase?

> Maybe we could also enable `clippy::unwrap_used` in this PR and get more coverage? `clippy::unwrap_used` is already enabled in zerocopy :-) > Also, we'll probably want some way of disabling...

Updated statistics for `clippy::expect_used`: We have one function that is documented as panicing as part of its public API (`FromZeros::new_box_slice_zeroed`). We have one function that called `expect` which we can...

> > One useful warning versus five useless warnings is not a great ratio. I'll let @joshlf decide whether you think that `clippy::expect_used` is worth the noise. > > I'm...

> With Rust merged into [GCC 13](https://www.phoronix.com/news/GCC-13-Rust-Merged), will that eventually make it possible to resolve this as the implementation matures? [rustc_codegen_gcc](https://github.com/rust-lang/rustc_codegen_gcc) is on track to be usable well before GCC's...