jrsala-auguration

[C++] Performance macros in header files

4

In the C++ client, the `DISABLE_BOUNDS_CHECKS` macro, if defined, is intended to make `AtomicBuffer` operations faster at the cost of safety. It is defined by file `aeron-client/src/main/cpp/CMakeLists.txt` when performing a...

Support scaling-related operations

2

This adds two endpoints that are new since 0.12.0. (also removes duplicated test `test_revert_job`) The API contract of the `/:job_id/scale` endpoint is not fully clear to me yet (see [this...

Make GzipOutputStream write directly to buffer of BufferedOutputStream

7

This is in order to save a potentially unnecessary copy into that 4kB buffer when the user already has a `BufferedOutputStream` at hand. I might have violated a few style...

Simple use of KJ_REQUIRE causes SIGSEGV

5

The following code causes a segfault ``` #include int main() { const char* myPtr = nullptr; KJ_REQUIRE(myPtr != nullptr, "Some message"); } ``` `KJ_REQUIRE` constructs a `DebugComparison` containing a `const...

Serialize#read is too eager to throw on EOF

2

I would like to generically read messages from some unspecified `ReadableByteChannel`, because that's what `Serialize#read` and `SerializePacked#read` accept so I write ```java static void processMessages(ReadableByteChannel channel) { // Loop until...

This is mostly a nitpick, and I'm not sure my analysis below is correct, so please correct me if I'm wrong. In `FragmentAssembler#handleFragment`, the term offset of the next fragment...