jrsala-auguration

Results 8 comments of jrsala-auguration

Hi Todd, thanks for your response, and no worries re. the delay. I'm afraid I did not explain the issue clearly. When **Aeron code** is compiled, the presence or absence...

Sure, happy with that. Thanks.

Hi @jonathanrcross, thanks for the help. I did not run any tests locally, so happy for you to take this over.

> I like the objective here, but I'm finding the code very hard to follow. I agree, I tried to factor out common bits into base classes, including the use...

I've given this a think, pretty sure the use of templates in some form is necessary unless we introduce inefficiencies. If we want `GzipOutputStream` to support both a `BufferedOutputStreamWrapper` it...

Hi Kenton, thanks for your response. I think this would work, and the only runtime costs would be at construction and destruction time and therefore negligible. I will try that.

I had to modify `BufferOutputStreamWrapper::write` in the case where it detects that a write has been made directly into its buffer. Without this change, `GzipOutputStream::pump` would fill the buffer and...

When `VectorOutputStream::getWriteBuffer()` is called, it grows the vector to make space. So for consistency it might be best to have `BufferedOutputStreamWrapper` similarly flush when `getWriteBuffer()` is called and there's no...