Jonathan R. Madsen

Results 199 comments of Jonathan R. Madsen

Try doing a `grep ^ElfUtils CMakeCache.txt` and see if there are any stale cached variables (probably a version one that isn't being updated) and then undefine it: `cmake -U ...`

With regard to #1264 and #1265 ## Features Removed There were no features which were removed. ## Features Added - Fatal Error is using cmake version that is too old...

> Is there a difference if the parent project uses set(FOO "Hello" CACHE) or option(FOO "" "Hello")? No. In CMake project mode, option is basically just shorthand for setting a...

> How are these cases handled for built-in variables like CMAKE_BUILD_SHARED? For example, if I want to have shared libs in the parent project but static libs from Dyninst. Dyninst...

This will be closed by #1101 > Does CMake automatically set MAKE to something other than GNU Make when using Ninja as a generator in this context? I'm pretty sure...

So this PR is _definitely_ going to break the test suite but that's kind of the point. When all the changes are in, all the stuff like this: ```cmake #...

@hainest For reference, here is the project (which has finally been open-sourced) that we are using Dyninst for: [omnitrace](https://github.com/AMDResearch/omnitrace) and the [docs](https://amdresearch.github.io/omnitrace)

@hainest This might be useful for the git blame issue I mentioned: https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame Particularly the creation of the .git-blame-ignore-revs file

> Does this need to be done before the other PRs? Not at all. The few changes to the source have been relatively minimal and aren't difficult to merge.