Jonathan R. Madsen

Results 199 comments of Jonathan R. Madsen

> I haven't run/tested this PR, but from looking at it I think it's taking the 1 approach. @mplegendre I don't think it is breaking `RTLD_NEXT` since this test snippet...

> I took the patch and tried it with our survey tool. It compiles but something seems to be wrong as we aren't getting our performance data gathered. So, more...

Turns out using `_dl_sym` is more problematic than it being a hidden symbol in recent glibc versions. It turns out in some situations, when gotcha calls it with RTLD_NEXT and...

Does the problem still exist if you reset the priority to point to the original function? I think this is done by resetting the priority to -1 or something like...

> assert is used in many places to enforce correctness constraints (I 100% agree this is not the right way to do this...), so it's unsurprising that a failure when...

This is interesting. It may simply be fixed by having the Dyninst submodule build boost bc I set it up to build and link to the static boost libraries so...

It's interesting bc the Dyninst team said they want to get rid of the building dependencies support. But this would be a strong case keeping that if Dyninst needs a...

I'm going to close this with the note that it is highly recommended to statically link boost, or at least compile boost with hidden visibility (I suspect that if your...

```console omnitrace -v -1 --print-instrumented functions -o /ccs/home/jjhu/crusher/libs-instrumented/libteuchosnumerics.so.13 ``` This doesn’t look right. You need to provide the library you want to instrument after a double-hyphen: ```console omnitrace -v -1...