Jon Johnson

Results 191 comments of Jon Johnson

Might be the "regular" I don't love. We have a license for everything.

Code looks good, assigning to @dartajax for visual review and merging.

Percy just needs approval of the changes @dartajax, because this header is on every page it's a lot of changes, but still worth checking through I think.

How can I help with this? Or, alternatively, is there a way to do this in application code today that I could document? Can I negate the `splitAtRoutes` regex or...

For some values of *slightly* I'd like to make an attempt to fix this in stable embroider and hopefully bring along anyone else that isn't on the bleeding edge. However,...

@Windvis thanks for the review. I think, but haven't gone back to confirm yet, that all of these issues are right off the embroider addon blueprint. My feeling is we...

This happens through the API in https://github.com/ilios/ilios/blob/master/src/Service/Directory.php#L61 and can be tested on an Ilios instance hooked up to a directory in the admin dashboard.

I prefere enhancing the search over changing the UI. Might be possible to do a better `OR` in ldap for both split and un-split terms.

That addon may be unmaintained, let's find out with a pull request. Looks like a pretty contained contribution @michaelchadwick https://github.com/search?q=repo%3Azonkyio%2Fember-web-app%20apple-mobile-web-app-capable&type=code want to create a PR on that repo or pair...