Jon Johnson
Jon Johnson
This would be a helpful signal from the framework. As an addon maintainer I sometimes (not nearly as much for the last year) get a bug report for pods that...
Thanks @wagenet and @MrChocolatine, I've incorporated your feedback.
@wagenet / @chriskrycho anything I should be doing to push this along or advocate for the change?
@wagenet I don't quite understand why this deprecation would be held up by that process. I'm not worried about my work here, take it or leave it, but I am...
That makes sense for `EmberArray`, but I don't understand why that prevents deprecating (or making internal only) `Ember.A()`. In every case I've seen the replacement for `Ember.A()` is either octane...
I agree that it should go behind a flag. Because many addons call `A()` on basically everything there are probably lots of components in production today that pass something through...
Using the config: ``` '@embroider/macros': { setConfig: { '@ember-data/store': { polyfillUUID: true, }, }, }, ``` In a brand new `pnpm` app results in `unable to resolve package @ember-data/store`. Steps:...
Thanks, @runspired I was able to dig into this with your info and discovered that [detection logic ED uses](https://github.com/emberjs/data/blob/47a71ca1538ba9e2d7dfa01bf048a2db897bdf5f/packages/store/addon/-private/record-arrays/identifier-array.ts#L381-L401) which used to happen [here](https://github.com/emberjs/ember.js/blame/1b557e97d540b1b2a608442038d502c029c580dc/packages/@ember/-internals/runtime/lib/mixins/array.js#L1809) seems to have been removed accidentally...
Turning Array prototype extensions back on has temporarily solved this for us so I'm confident that it is the clobbering of the record by `Ember.A()` that causes the issue. I...
Test's are hanging and not completing. That's why we're not getting screenshots. Not sure if it's transient or an issue in this PR. I restarted them, hung in the same...